Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(148)

Unified Diff: telemetry/telemetry/internal/story_runner.py

Issue 2656493002: Register metric Histogram names. (Closed)
Patch Set: rebase Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | telemetry/telemetry/web_perf/timeline_based_measurement.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: telemetry/telemetry/internal/story_runner.py
diff --git a/telemetry/telemetry/internal/story_runner.py b/telemetry/telemetry/internal/story_runner.py
index 4242b78b8c85b08ca070dca31aac268441771299..8e84ac6a5c12ac540c79a822c46dc4957ea898f0 100644
--- a/telemetry/telemetry/internal/story_runner.py
+++ b/telemetry/telemetry/internal/story_runner.py
@@ -26,6 +26,8 @@ from telemetry.value import failure
from telemetry.value import skip
from telemetry.web_perf import story_test
+from tracing.metrics import all_histogram_names
+
class ArchiveError(Exception):
pass
@@ -69,7 +71,13 @@ def ProcessCommandLineArgs(parser, args):
def _RunStoryAndProcessErrorIfNeeded(story, results, state, test):
def ProcessError(description=None):
state.DumpStateUponFailure(story, results)
- results.AddValue(failure.FailureValue(story, sys.exc_info(), description))
+ if test.GetTimelineBasedMetrics():
+ for unused_name in all_histogram_names.AllHistogramNames(
+ test.GetTimelineBasedMetrics()):
+ pass # TODO(benjhayden): Synthesize Failure Histograms here.
+ else:
+ results.AddValue(failure.FailureValue(story, sys.exc_info(), description))
+
try:
# TODO(mikecase): Remove this logging once Android perf bots are swarmed.
# crbug.com/678282
« no previous file with comments | « no previous file | telemetry/telemetry/web_perf/timeline_based_measurement.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698