Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Side by Side Diff: tracing/tracing/metrics/v8/runtime_stats_metric.html

Issue 2656493002: Register metric Histogram names. (Closed)
Patch Set: rebase Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « tracing/tracing/metrics/v8/gc_metric.html ('k') | tracing/tracing/metrics/v8/v8_metrics.html » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 <!DOCTYPE html> 1 <!DOCTYPE html>
2 <!-- 2 <!--
3 Copyright 2016 The Chromium Authors. All rights reserved. 3 Copyright 2016 The Chromium Authors. All rights reserved.
4 Use of this source code is governed by a BSD-style license that can be 4 Use of this source code is governed by a BSD-style license that can be
5 found in the LICENSE file. 5 found in the LICENSE file.
6 --> 6 -->
7 7
8 <link rel="import" href="/tracing/base/range.html"> 8 <link rel="import" href="/tracing/base/range.html">
9 <link rel="import" href="/tracing/base/unit.html"> 9 <link rel="import" href="/tracing/base/unit.html">
10 <link rel="import" href="/tracing/extras/v8/runtime_stats_entry.html"> 10 <link rel="import" href="/tracing/extras/v8/runtime_stats_entry.html">
(...skipping 228 matching lines...) Expand 10 before | Expand all | Expand 10 after
239 } 239 }
240 240
241 // Compute runtimeStats in each of the UE buckets and also compute 241 // Compute runtimeStats in each of the UE buckets and also compute
242 // runtimeStats on all of the samples. The values in UE buckets do not add 242 // runtimeStats on all of the samples. The values in UE buckets do not add
243 // up to the total of all samples, since we duplicate some of the samples in 243 // up to the total of all samples, since we duplicate some of the samples in
244 // multiple buckets when the UEs overlap. 244 // multiple buckets when the UEs overlap.
245 computeRuntimeStatsBucketOnUE(histograms, v8ThreadSlices, 245 computeRuntimeStatsBucketOnUE(histograms, v8ThreadSlices,
246 v8SlicesBucketOnUEMap); 246 v8SlicesBucketOnUEMap);
247 } 247 }
248 248
249 tr.metrics.MetricRegistry.register(runtimeStatsTotalMetric); 249 tr.metrics.MetricRegistry.register(runtimeStatsTotalMetric, {
250 tr.metrics.MetricRegistry.register(runtimeStatsMetric); 250 histogramNames: new Set([]),
251 });
252 tr.metrics.MetricRegistry.register(runtimeStatsMetric, {
253 histogramNames: new Set([]),
254 });
251 255
252 return { 256 return {
253 runtimeStatsMetric, 257 runtimeStatsMetric,
254 runtimeStatsTotalMetric, 258 runtimeStatsTotalMetric,
255 }; 259 };
256 }); 260 });
257 </script> 261 </script>
OLDNEW
« no previous file with comments | « tracing/tracing/metrics/v8/gc_metric.html ('k') | tracing/tracing/metrics/v8/v8_metrics.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698