Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(219)

Issue 26540002: Don't run main if library failed to import (Closed)

Created:
7 years, 2 months ago by vsm
Modified:
7 years, 2 months ago
Reviewers:
Jacob
CC:
reviews+dom_dartlang.org
Visibility:
Public.

Description

Don't run main if library failed to import My earlier CL ran main even if certain libraries (e.g., dart:io) were not available. R=jacobr@google.com Committed: https://src.chromium.org/viewvc/multivm?view=rev&revision=1420

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -1 line) Patch
M Source/bindings/dart/DartApplicationLoader.cpp View 3 chunks +7 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
vsm
7 years, 2 months ago (2013-10-08 18:08:06 UTC) #1
Jacob
lgtm
7 years, 2 months ago (2013-10-08 18:25:55 UTC) #2
vsm
7 years, 2 months ago (2013-10-08 19:23:39 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r1420 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698