Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(536)

Unified Diff: tools/gn/unique_vector.h

Issue 26537002: Add a UniqueVector class to GN (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: REview comments, remove npos Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/gn/target_unittest.cc ('k') | tools/gn/unique_vector_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/gn/unique_vector.h
diff --git a/tools/gn/unique_vector.h b/tools/gn/unique_vector.h
new file mode 100644
index 0000000000000000000000000000000000000000..16f797efe43fb061b8b0cf09f27afd2f5230d98a
--- /dev/null
+++ b/tools/gn/unique_vector.h
@@ -0,0 +1,189 @@
+// Copyright 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef TOOLS_GN_UNIQUE_VECTOR_H_
+#define TOOLS_GN_UNIQUE_VECTOR_H_
+
+#include <algorithm>
+
+#include "base/containers/hash_tables.h"
+
+namespace internal {
+
+// This lass allows us to insert things by reference into a hash table which
+// avoids copies. The hash function of a UniquifyRef is that of the object it
+// points to.
+//
+// There are two ways it can store data: (1) by (vector*, index) which is used
+// to refer to the array in UniqueVector and make it work even when the
+// underlying vector is reallocated; (2) by T* which is used to do lookups
+// into the hash table of things that aren't in a vector yet.
+//
+// It also caches the hash value which allows us to query and then insert
+// without recomputing the hash.
+template<typename T>
+class UniquifyRef {
+ public:
+ UniquifyRef()
+ : value_(NULL),
+ vect_(NULL),
+ index_(static_cast<size_t>(-1)),
+ hash_val_(0) {
+ }
+
+ // Initialize with a pointer to a value.
+ UniquifyRef(const T* v)
+ : value_(v),
+ vect_(NULL),
+ index_(static_cast<size_t>(-1)) {
+ FillHashValue();
+ }
+
+ // Initialize with an array + index.
+ UniquifyRef(const std::vector<T>* v, size_t i)
+ : value_(NULL),
+ vect_(v),
+ index_(i) {
+ FillHashValue();
+ }
+
+ // Initialize with an array + index and a known hash value to prevent
+ // re-hashing.
+ UniquifyRef(const std::vector<T>* v, size_t i, size_t hash_value)
+ : value_(NULL),
+ vect_(v),
+ index_(i),
+ hash_val_(hash_value) {
+ }
+
+ const T& value() const { return value_ ? *value_ : (*vect_)[index_]; }
+ size_t hash_val() const { return hash_val_; }
+ size_t index() const { return index_; }
+
+ private:
+ void FillHashValue() {
+#if defined(COMPILER_GCC)
+ BASE_HASH_NAMESPACE::hash<T> h;
+ hash_val_ = h(value());
+#elif defined(COMPILER_MSVC)
+ hash_val_ = BASE_HASH_NAMESPACE::hash_value(value());
+#else
+ #error write me
+#endif // COMPILER...
+ }
+
+ // When non-null, points to the object.
+ const T* value_;
+
+ // When value is null these are used.
+ const std::vector<T>* vect_;
+ size_t index_;
+
+ size_t hash_val_;
+};
+
+template<typename T> inline bool operator==(const UniquifyRef<T>& a,
+ const UniquifyRef<T>& b) {
+ return a.value() == b.value();
+}
+
+template<typename T> inline bool operator<(const UniquifyRef<T>& a,
+ const UniquifyRef<T>& b) {
+ return a.value() < b.value();
+}
+
+} // namespace internal
+
+namespace BASE_HASH_NAMESPACE {
+
+#if defined(COMPILER_GCC)
+template<typename T> struct hash< internal::UniquifyRef<T> > {
+ std::size_t operator()(const internal::UniquifyRef<T>& v) const {
+ return v.hash_val();
+ }
+};
+#elif defined(COMPILER_MSVC)
+template<typename T>
+inline size_t hash_value(const internal::UniquifyRef<T>& v) {
+ return v.hash_val();
+}
+#endif // COMPILER...
+
+} // namespace BASE_HASH_NAMESPACE
+
+// An ordered set optimized for GN's usage. Such sets are used to store lists
+// of configs and libraries, and are appended to but not randomly inserted
+// into.
+template<typename T>
+class UniqueVector {
+ public:
+ typedef std::vector<T> Vector;
+ typedef typename Vector::iterator iterator;
+ typedef typename Vector::const_iterator const_iterator;
+
+ const Vector& vector() const { return vector_; }
+ size_t size() const { return vector_.size(); }
+ bool empty() const { return vector_.empty(); }
+ void clear() { vector_.clear(); set_.clear(); }
+ void reserve(size_t s) { vector_.reserve(s); }
+
+ const T& operator[](size_t index) const { return vector_[index]; }
+
+ const_iterator begin() const { return vector_.begin(); }
+ iterator begin() { return vector_.begin(); }
+ const_iterator end() const { return vector_.end(); }
+ iterator end() { return vector_.end(); }
+
+ // Returns true if the item was appended, false if it already existed (and
+ // thus the vector was not modified).
+ bool push_back(const T& t) {
+ Ref ref(&t);
+ if (set_.find(ref) != set_.end())
+ return false; // Already have this one.
+
+ vector_.push_back(t);
+ set_.insert(Ref(&vector_, vector_.size() - 1, ref.hash_val()));
+ return true;
+ }
+
+ // Like push_back but swaps in the type to avoid a copy.
+ bool PushBackViaSwap(T* t) {
+ using std::swap;
+
+ Ref ref(t);
+ if (set_.find(ref) != set_.end())
+ return false; // Already have this one.
+
+ size_t new_index = vector_.size();
+ vector_.resize(new_index + 1);
+ swap(vector_[new_index], *t);
+ set_.insert(Ref(&vector_, vector_.size() - 1, ref.hash_val()));
+ return true;
+ }
+
+ // Appends a range of items from an iterator.
+ template<typename iter> void Append(const iter& begin, const iter& end) {
+ for (iter i = begin; i != end; ++i)
+ push_back(*i);
+ }
+
+ // Returns the index of the item matching the given value in the list, or
+ // (size_t)(-1) if it's not found.
+ size_t IndexOf(const T& t) const {
+ Ref ref(&t);
+ typename HashSet::const_iterator found = set_.find(ref);
+ if (found == set_.end())
+ return static_cast<size_t>(-1);
+ return found->index();
+ }
+
+ private:
+ typedef internal::UniquifyRef<T> Ref;
+ typedef base::hash_set<Ref> HashSet;
+
+ HashSet set_;
+ Vector vector_;
+};
+
+#endif // TOOLS_GN_UNIQUE_VECTOR_H_
« no previous file with comments | « tools/gn/target_unittest.cc ('k') | tools/gn/unique_vector_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698