Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(571)

Unified Diff: tools/gn/header_checker.cc

Issue 26537002: Add a UniqueVector class to GN (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: REview comments, remove npos Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/gn/gn.gyp ('k') | tools/gn/label.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/gn/header_checker.cc
diff --git a/tools/gn/header_checker.cc b/tools/gn/header_checker.cc
index 62a0f44d580baa41a03d2938fd6f36dc0b7d6ba7..f2c9db51df76ff3ab70e737655aa06bb952cb3e5 100644
--- a/tools/gn/header_checker.cc
+++ b/tools/gn/header_checker.cc
@@ -64,7 +64,8 @@ bool ConfigHasCompilerSettings(const Config* config) {
// Returns true if the given target has any direct dependent configs with
// compiler settings in it.
bool HasDirectDependentCompilerSettings(const Target* target) {
- const LabelConfigVector& direct = target->direct_dependent_configs();
+ const UniqueVector<LabelConfigPair>& direct =
+ target->direct_dependent_configs();
for (size_t i = 0; i < direct.size(); i++) {
if (ConfigHasCompilerSettings(direct[i].ptr))
return true;
@@ -431,7 +432,8 @@ bool HeaderChecker::DoDirectDependentConfigsApply(
// The forward list on this target should have contained in it the target
// at the next lower level.
- const LabelTargetVector& forwarded = chain[i]->forward_dependent_configs();
+ const UniqueVector<LabelTargetPair>& forwarded =
+ chain[i]->forward_dependent_configs();
if (std::find_if(forwarded.begin(), forwarded.end(),
LabelPtrPtrEquals<Target>(chain[i - 1])) ==
forwarded.end()) {
« no previous file with comments | « tools/gn/gn.gyp ('k') | tools/gn/label.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698