Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(294)

Unified Diff: tools/gn/command_desc.cc

Issue 26537002: Add a UniqueVector class to GN (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: REview comments, remove npos Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/gn/builder.cc ('k') | tools/gn/gn.gyp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/gn/command_desc.cc
diff --git a/tools/gn/command_desc.cc b/tools/gn/command_desc.cc
index e24f0e44f02617548f14aece8db2d5c848024249..f477e5aed6a1a4a1ac7f03ef4b2350e041d5e0d5 100644
--- a/tools/gn/command_desc.cc
+++ b/tools/gn/command_desc.cc
@@ -250,8 +250,27 @@ void PrintConfigsVector(const Target* target,
}
}
+void PrintConfigsVector(const Target* target,
+ const UniqueVector<LabelConfigPair>& configs,
+ const std::string& heading,
+ bool display_header) {
+ if (configs.empty())
+ return;
+
+ // Don't sort since the order determines how things are processed.
+ if (display_header)
+ OutputString("\n" + heading + " (in order applying):\n");
+
+ Label toolchain_label = target->label().GetToolchainLabel();
+ for (size_t i = 0; i < configs.size(); i++) {
+ OutputString(" " +
+ configs[i].label.GetUserVisibleName(toolchain_label) + "\n");
+ }
+}
+
void PrintConfigs(const Target* target, bool display_header) {
- PrintConfigsVector(target, target->configs(), "configs", display_header);
+ PrintConfigsVector(target, target->configs().vector(), "configs",
+ display_header);
}
void PrintDirectDependentConfigs(const Target* target, bool display_header) {
« no previous file with comments | « tools/gn/builder.cc ('k') | tools/gn/gn.gyp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698