Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Unified Diff: tools/gn/builder.h

Issue 26537002: Add a UniqueVector class to GN (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: REview comments, remove npos Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/gn/BUILD.gn ('k') | tools/gn/builder.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/gn/builder.h
diff --git a/tools/gn/builder.h b/tools/gn/builder.h
index cdb60fec859983c304e13ed17daa102cd23840a8..654a6ad70460e4fb9b60dc58c132ff6bc74e46ee 100644
--- a/tools/gn/builder.h
+++ b/tools/gn/builder.h
@@ -12,6 +12,7 @@
#include "tools/gn/builder_record.h"
#include "tools/gn/label.h"
#include "tools/gn/label_ptr.h"
+#include "tools/gn/unique_vector.h"
class Config;
class Err;
@@ -84,6 +85,9 @@ class Builder : public base::RefCountedThreadSafe<Builder> {
const LabelConfigVector& configs,
Err* err);
bool AddDeps(BuilderRecord* record,
+ const UniqueVector<LabelConfigPair>& configs,
+ Err* err);
+ bool AddDeps(BuilderRecord* record,
const LabelTargetVector& targets,
Err* err);
bool AddToolchainDep(BuilderRecord* record,
@@ -112,7 +116,7 @@ class Builder : public base::RefCountedThreadSafe<Builder> {
// that everything should be resolved by this point, so will return an error
// if anything isn't found or if the type doesn't match.
bool ResolveDeps(LabelTargetVector* deps, Err* err);
- bool ResolveConfigs(LabelConfigVector* configs, Err* err);
+ bool ResolveConfigs(UniqueVector<LabelConfigPair>* configs, Err* err);
bool ResolveForwardDependentConfigs(Target* target, Err* err);
// Given a list of unresolved records, tries to find any circular
« no previous file with comments | « tools/gn/BUILD.gn ('k') | tools/gn/builder.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698