base/debug/stack_trace_win.cc - Issue 26537002: Add a UniqueVector class to GN

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/debug/stack_trace_win.cc

Issue 26537002: Add a UniqueVector class to GN (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: REview comments, remove npos Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: base/debug/stack_trace_win.cc

diff --git a/base/debug/stack_trace_win.cc b/base/debug/stack_trace_win.cc

index 6393db326ee28d7f4a68ef322582b4a0914107e3..8df6fc6e3e6cb21931540d46c6f6d162314c153c 100644

--- a/base/debug/stack_trace_win.cc

+++ b/base/debug/stack_trace_win.cc

@@ -263,7 +263,7 @@ void StackTrace::OutputToStream(std::ostream* os) const {

if (error != ERROR_SUCCESS) {

(*os) << "Error initializing symbols (" << error

<< "). Dumping unresolved backtrace:\n";

- for (int i = 0; (i < count_) && os->good(); ++i) {

+ for (size_t i = 0; (i < count_) && os->good(); ++i) {

(*os) << "\t" << trace_[i] << "\n";

}

} else {

« no previous file with comments | « base/BUILD.gn ('k') | tools/gn/BUILD.gn » ('j') | no next file with comments »