src/compiler/s390/code-generator-s390.cc - Issue 2649703002: [Atomics] Make Atomics.compareExchange a builtin using TF

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/compiler/s390/code-generator-s390.cc

Issue 2649703002: [Atomics] Make Atomics.compareExchange a builtin using TF (Closed)

Patch Set: rebase and move cmpxchg to builtins-sharedarraybuffer-gen.cc Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/compiler/s390/code-generator-s390.cc

diff --git a/src/compiler/s390/code-generator-s390.cc b/src/compiler/s390/code-generator-s390.cc

index 0b531aa036ae26564efda860c89c6e081d77ee1a..348bdd20c9abbefd5b95201b4adfbb17fc2c1cf4 100644

--- a/src/compiler/s390/code-generator-s390.cc

+++ b/src/compiler/s390/code-generator-s390.cc

@@ -2414,6 +2414,14 @@ CodeGenerator::CodeGenResult CodeGenerator::AssembleArchInstruction(

__ bne(&do_cs, Label::kNear);

break;

}

+ case kAtomicCompareExchangeInt8:

+ case kAtomicCompareExchangeUint8:

+ case kAtomicCompareExchangeInt16:

+ case kAtomicCompareExchangeUint16:

+ case kAtomicCompareExchangeWord32: {

+ UNREACHABLE();

+ break;

+ }

default:

UNREACHABLE();

break;