Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Issue 26490003: Reapply "Move isolate loading to a separate loader isolate." (Closed)

Created:
7 years, 2 months ago by vsm
Modified:
7 years, 2 months ago
Reviewers:
Emily Fortuna
CC:
reviews+dom_dartlang.org
Visibility:
Public.

Description

Revert "Revert "Move isolate loading to a separate loader isolate."" The first patch set is the original CL lgtmed by jacobr. The second patch is the fix. R=efortuna@google.com Committed: https://src.chromium.org/viewvc/multivm?view=rev&revision=1418

Patch Set 1 #

Patch Set 2 : Initialize flag properly #

Unified diffs Side-by-side diffs Delta from patch set Stats (+584 lines, -291 lines) Patch
M LayoutTests/dart/script-onerror-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/dart/DartApplicationLoader.h View 4 chunks +5 lines, -20 lines 0 comments Download
M Source/bindings/dart/DartApplicationLoader.cpp View 8 chunks +51 lines, -222 lines 0 comments Download
A Source/bindings/dart/DartAsyncLoader.h View 1 chunk +116 lines, -0 lines 0 comments Download
A Source/bindings/dart/DartAsyncLoader.cpp View 1 1 chunk +263 lines, -0 lines 0 comments Download
M Source/bindings/dart/DartController.h View 3 chunks +5 lines, -0 lines 0 comments Download
M Source/bindings/dart/DartController.cpp View 8 chunks +72 lines, -48 lines 0 comments Download
M Source/bindings/dart/DartDOMData.h View 3 chunks +6 lines, -0 lines 0 comments Download
M Source/bindings/dart/DartDOMData.cpp View 2 chunks +13 lines, -0 lines 0 comments Download
M Source/bindings/dart/DartUtilities.h View 2 chunks +10 lines, -0 lines 0 comments Download
M Source/bindings/dart/DartUtilities.cpp View 1 chunk +40 lines, -0 lines 0 comments Download
M Source/bindings/dart/gyp/overrides.gypi View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
vsm
7 years, 2 months ago (2013-10-08 16:36:00 UTC) #1
Emily Fortuna
lgtm
7 years, 2 months ago (2013-10-08 16:38:32 UTC) #2
vsm
7 years, 2 months ago (2013-10-08 17:32:10 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r1418 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698