Chromium Code Reviews| Index: chrome/browser/extensions/crx_installer.h | 
| diff --git a/chrome/browser/extensions/crx_installer.h b/chrome/browser/extensions/crx_installer.h | 
| index 8e3575bd4ff3a1fd3142afcb09c0b2deb2cd05e8..5036bac58eceb3246bf644398b1c787a86955883 100644 | 
| --- a/chrome/browser/extensions/crx_installer.h | 
| +++ b/chrome/browser/extensions/crx_installer.h | 
| @@ -76,6 +76,12 @@ class CrxInstaller | 
| NumOffStoreInstallAllowReasons | 
| }; | 
| + enum AllowSilent { | 
| + GRANT_AFTER_PROMPT, // No silent install, show a prompt instead. | 
| 
 
Yoyo Zhou
2014/05/01 22:53:44
I think the "grant" here is superfluous. But as ka
 
Marijn Kruisselbrink
2014/05/05 20:45:36
Okay, I decided to skip the idea of having an enum
 
 | 
| + GRANT_SILENTLY, // Silently install and grant all permissions. | 
| + SILENTLY_DONT_GRANT // Silently install, but don't grant any permissions. | 
| + }; | 
| + | 
| // Extensions will be installed into service->install_directory(), then | 
| // registered with |service|. This does a silent install - see below for | 
| // other options. | 
| @@ -130,8 +136,10 @@ class CrxInstaller | 
| bool delete_source() const { return delete_source_; } | 
| void set_delete_source(bool val) { delete_source_ = val; } | 
| - bool allow_silent_install() const { return allow_silent_install_; } | 
| - void set_allow_silent_install(bool val) { allow_silent_install_ = val; } | 
| + AllowSilent allow_silent_install() const { return allow_silent_install_; } | 
| + void set_allow_silent_install(AllowSilent val) { | 
| + allow_silent_install_ = val; | 
| + } | 
| bool is_gallery_install() const { | 
| return (creation_flags_ & Extension::FROM_WEBSTORE) > 0; | 
| @@ -346,7 +354,7 @@ class CrxInstaller | 
| // Allows for the possibility of a normal install (one in which a |client| | 
| // is provided in the ctor) to procede without showing the permissions prompt | 
| // dialog. | 
| - bool allow_silent_install_; | 
| + AllowSilent allow_silent_install_; | 
| // The value of the content type header sent with the CRX. | 
| // Ignorred unless |require_extension_mime_type_| is true. |