Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(133)

Issue 2645953005: Add more unit tests for ImageResource's DecodeError (Closed)

Created:
3 years, 11 months ago by hiroshige
Modified:
3 years, 11 months ago
Reviewers:
yhirano
CC:
chromium-reviews, blink-reviews, loading-reviews_chromium.org, tyoshino+watch_chromium.org, Nate Chapin, gavinp+loader_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add more unit tests for ImageResource's DecodeError This CL - Adds a unit test where DecodeError is caused by the empty body, and - Adds assertions that the state is DecodeError when imageNotifyFinished() is called. BUG=667641, 677188 Review-Url: https://codereview.chromium.org/2645953005 Cr-Commit-Position: refs/heads/master@{#445904} Committed: https://chromium.googlesource.com/chromium/src/+/ab84059f6799efdab7036fe076f2a35d1593d1a6

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : fix #

Patch Set 4 : add unit test for reloading for decode error in didFinishLoading #

Patch Set 5 : Refactor reloading tests #

Patch Set 6 : Split reloading tests. #

Patch Set 7 : Rebase #

Patch Set 8 : Rebase #

Patch Set 9 : Rebase #

Patch Set 10 : Include path fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -0 lines) Patch
M third_party/WebKit/Source/core/loader/resource/ImageResourceTest.cpp View 1 2 3 4 5 6 7 8 9 2 chunks +33 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/loader/resource/MockImageResourceObserver.h View 1 2 3 4 5 6 7 8 9 3 chunks +5 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/loader/resource/MockImageResourceObserver.cpp View 1 chunk +1 line, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 22 (16 generated)
hiroshige
PTAL.
3 years, 11 months ago (2017-01-22 20:48:18 UTC) #10
yhirano
lgtm
3 years, 11 months ago (2017-01-23 06:08:16 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2645953005/160001
3 years, 11 months ago (2017-01-24 21:39:52 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_compile_dbg_ng/builds/227760)
3 years, 11 months ago (2017-01-24 21:51:17 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2645953005/180001
3 years, 11 months ago (2017-01-24 22:25:25 UTC) #19
commit-bot: I haz the power
3 years, 11 months ago (2017-01-25 01:42:17 UTC) #22
Message was sent while issue was closed.
Committed patchset #10 (id:180001) as
https://chromium.googlesource.com/chromium/src/+/ab84059f6799efdab7036fe076f2...

Powered by Google App Engine
This is Rietveld 408576698