Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Issue 2645813007: PDF: Fix a failing find-in-page corner case. (Closed)

Created:
3 years, 11 months ago by Lei Zhang
Modified:
3 years, 11 months ago
Reviewers:
dsinclair
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

PDF: Fix a failing find-in-page corner case. When the result is the text at the end of a page, the text highlight for the search result is incorrect. BUG=683414 Review-Url: https://codereview.chromium.org/2645813007 Cr-Commit-Position: refs/heads/master@{#445718} Committed: https://chromium.googlesource.com/chromium/src/+/3ed6d4447aba42525fc8a0020320325542925049

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -8 lines) Patch
M pdf/pdfium/pdfium_engine.h View 2 chunks +2 lines, -3 lines 0 comments Download
M pdf/pdfium/pdfium_engine.cc View 4 chunks +18 lines, -5 lines 0 comments Download

Messages

Total messages: 16 (10 generated)
Lei Zhang
3 years, 11 months ago (2017-01-21 00:11:21 UTC) #3
dsinclair
lgtm
3 years, 11 months ago (2017-01-23 14:53:13 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2645813007/1
3 years, 11 months ago (2017-01-23 14:53:25 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_compile_dbg_ng/builds/334312) win_clang on master.tryserver.chromium.win (JOB_FAILED, ...
3 years, 11 months ago (2017-01-23 14:54:17 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2645813007/1
3 years, 11 months ago (2017-01-24 13:50:43 UTC) #13
commit-bot: I haz the power
3 years, 11 months ago (2017-01-24 14:30:26 UTC) #16
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/3ed6d4447aba42525fc8a0020320...

Powered by Google App Engine
This is Rietveld 408576698