Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(743)

Issue 2644853005: Update project/service config references. (Closed)

Created:
3 years, 11 months ago by dnj
Modified:
3 years, 11 months ago
Reviewers:
iannucci
CC:
chromium-reviews, infra-reviews+luci-go_chromium.org, maruel+w_chromium.org, tandrii+luci-go_chromium.org
Target Ref:
refs/heads/master
Project:
luci-go
Visibility:
Public.

Description

Update project/service config references. Small cleanup to update project/service config references. BUG=chromium:682465 TEST=None Review-Url: https://codereview.chromium.org/2644853005 Committed: https://github.com/luci/luci-go/commit/46e4d75b7f41409c78bcd0c866120a49559440c3

Patch Set 1 #

Patch Set 2 : Update project/service config references. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -8 lines) Patch
M common/runtime/profiling/profiler.go View 1 chunk +1 line, -1 line 0 comments Download
M logdog/api/config/svcconfig/util.go View 1 chunk +10 lines, -2 lines 0 comments Download
M logdog/api/config/svcconfig/validate/main.go View 1 chunk +1 line, -1 line 0 comments Download
M logdog/appengine/coordinator/config/config.go View 1 chunk +1 line, -1 line 0 comments Download
M logdog/appengine/coordinator/config/projects.go View 2 chunks +1 line, -2 lines 0 comments Download
M logdog/appengine/coordinator/endpoints/services/getConfig_test.go View 1 chunk +1 line, -1 line 0 comments Download

Dependent Patchsets:

Messages

Total messages: 8 (4 generated)
dnj
PTAL
3 years, 11 months ago (2017-01-20 23:39:43 UTC) #2
iannucci
lgtm
3 years, 11 months ago (2017-01-20 23:46:48 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2644853005/20001
3 years, 11 months ago (2017-01-20 23:56:48 UTC) #5
commit-bot: I haz the power
3 years, 11 months ago (2017-01-21 00:03:47 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://github.com/luci/luci-go/commit/46e4d75b7f41409c78bcd0c866120a49559440c3

Powered by Google App Engine
This is Rietveld 408576698