Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(767)

Unified Diff: logdog/server/service/config/poller_test.go

Issue 2644413002: Add independent config poller service. (Closed)
Patch Set: interval -> period Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « logdog/server/service/config/poller.go ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: logdog/server/service/config/poller_test.go
diff --git a/logdog/server/service/config/poller_test.go b/logdog/server/service/config/poller_test.go
new file mode 100644
index 0000000000000000000000000000000000000000..6b454c21ce3592bda8c6466cf27014cfcf6d9774
--- /dev/null
+++ b/logdog/server/service/config/poller_test.go
@@ -0,0 +1,122 @@
+// Copyright 2016 The LUCI Authors. All rights reserved.
+// Use of this source code is governed under the Apache License, Version 2.0
+// that can be found in the LICENSE file.
+
+package config
+
+import (
+ "sync"
+ "testing"
+ "time"
+
+ "github.com/golang/protobuf/proto"
+ "github.com/luci/luci-go/common/clock"
+ "github.com/luci/luci-go/common/clock/testclock"
+ "github.com/luci/luci-go/common/config/impl/memory"
+ "github.com/luci/luci-go/logdog/api/config/svcconfig"
+ "github.com/luci/luci-go/luci_config/server/cfgclient/backend/testconfig"
+
+ "golang.org/x/net/context"
+
+ . "github.com/smartystreets/goconvey/convey"
+)
+
+func TestPoller(t *testing.T) {
+ t.Parallel()
+
+ Convey(`Using in-memory configuration manager options`, t, func() {
+ c := context.Background()
+ c, tc := testclock.UseTime(c, testclock.TestTimeLocal)
+
+ // In-memory configuration service.
+ cfg := &svcconfig.Config{
+ Transport: &svcconfig.Transport{
+ Type: &svcconfig.Transport_Pubsub{
+ Pubsub: &svcconfig.Transport_PubSub{
+ Project: "foo",
+ Topic: "bar",
+ Subscription: "baz",
+ },
+ },
+ },
+ }
+ cset := memory.ConfigSet{
+ "test-configuration.cfg": proto.MarshalTextString(cfg),
+ }
+
+ mc := memory.New(map[string]memory.ConfigSet{
+ "svcconfig/logdog/test": cset,
+ })
+ c = testconfig.WithCommonClient(c, mc)
+
+ p := ChangePoller{
+ ConfigSet: "svcconfig/logdog/test",
+ Path: "test-configuration.cfg",
+ }
+ So(p.Refresh(c), ShouldBeNil)
+ initHash := p.ContentHash
+
+ Convey(`With an OnChange function installed.`, func() {
+ changeDetectedC := make(chan bool, 1)
+ p.Period = time.Second
+ p.OnChange = func() {
+ changeDetectedC <- true
+ }
+
+ timeAdvanceC := make(chan time.Duration)
+ tc.SetTimerCallback(func(time.Duration, clock.Timer) {
+ t, ok := <-timeAdvanceC
+ if ok {
+ tc.Add(t)
+ }
+ })
+
+ c, cancelFunc := context.WithCancel(c)
+
+ doneC := make(chan struct{})
+ go func() {
+ p.Run(c)
+ close(doneC)
+ }()
+
+ var shutdownOnce sync.Once
+ shutdown := func() {
+ shutdownOnce.Do(func() {
+ cancelFunc()
+ close(timeAdvanceC)
+ <-doneC
+ })
+ }
+ defer shutdown()
+
+ Convey(`When the configuration changes`, func() {
+ cfg.Transport.GetPubsub().Project = "qux"
+ cset[string(p.Path)] = proto.MarshalTextString(cfg)
+
+ Convey(`Will execute the OnChange function if the configuration changes.`, func() {
+ timeAdvanceC <- time.Second
+ So(<-changeDetectedC, ShouldBeTrue)
+ So(p.ContentHash, ShouldNotEqual, initHash)
+ })
+ })
+
+ Convey(`Will do nothing if the configuration doesn't change.`, func() {
+ // Advancing time twice ensures that the poll loop has processed at
+ // least one non-changing reload.
+ timeAdvanceC <- time.Second
+ timeAdvanceC <- time.Second
+
+ changeDetected := false
+ select {
+ case <-changeDetectedC:
+ changeDetected = true
+ default:
+ }
+ So(changeDetected, ShouldBeFalse)
+
+ shutdown()
+ So(p.ContentHash, ShouldEqual, initHash)
+ })
+ })
+ })
+}
« no previous file with comments | « logdog/server/service/config/poller.go ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698