DevTools: display 'Pending authentication' message upon raw usb debugging.

chrome/browser/devtools/port_forwarding_controller.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/devtools/port_forwarding_controller.h"
 
 #include <algorithm>
 #include <map>
 
 #include "base/bind.h"
@@ skipping 577 matching lines @@
     it->second->Shutdown();
 }
 
 PortForwardingController::DevicesStatus
 PortForwardingController::UpdateDeviceList(
     const DevToolsAdbBridge::RemoteDevices& devices) {
   DevicesStatus status;
   for (DevToolsAdbBridge::RemoteDevices::const_iterator it = devices.begin();
        it != devices.end(); ++it) {
     scoped_refptr<DevToolsAdbBridge::RemoteDevice> device = *it;
-    Registry::iterator rit = registry_.find(device->serial());
+    Registry::iterator rit = registry_.find(device->GetSerial());

[Vladislav Kaznacheev, 2013/10/08 16:42:37]

How about adding device->IsConnected check and not creating a new Connection if
false?

[pfeldman, 2013/10/08 17:11:04]

Yep, thanks.

     if (rit == registry_.end()) {
       std::string socket = FindBestSocketForTethering(device->browsers());
-      if (!socket.empty() || device->serial().empty()) {
+      if (!socket.empty() || device->GetSerial().empty()) {
         // Will delete itself when disconnected.
         new Connection(
           &registry_, device->device(), socket, adb_thread_, pref_service_);
       }
     } else {
-      status[device->serial()] = (*rit).second->GetPortStatusMap();
+      status[device->GetSerial()] = (*rit).second->GetPortStatusMap();
     }
   }
   return status;
 }
 
 // static
 PortForwardingController::Factory*
 PortForwardingController::Factory::GetInstance() {
   return Singleton<PortForwardingController::Factory>::get();
 }
@@ skipping 11 matching lines @@
           BrowserContextDependencyManager::GetInstance()) {}
 
 PortForwardingController::Factory::~Factory() {}
 
 BrowserContextKeyedService*
 PortForwardingController::Factory::BuildServiceInstanceFor(
     content::BrowserContext* context) const {
   Profile* profile = Profile::FromBrowserContext(context);
   return new PortForwardingController(profile->GetPrefs());
 }