Add OnCompileError handler and v8::CompileError debug event

src/isolate.cc

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <stdlib.h>
 
 #include "v8.h"
 
 #include "ast.h"
 #include "bootstrapper.h"
@@ skipping 971 matching lines @@
     // Only report the exception if the external handler is verbose.
     return try_catch_handler()->is_verbose_;
   } else {
     // Report the exception if it isn't caught by JavaScript code.
     return handler == NULL;
   }
 }
 
 
 bool Isolate::IsErrorObject(Handle<Object> obj) {
+  return IsTypeObject(obj,
+    factory()->InternalizeOneByteString(STATIC_ASCII_VECTOR("$Error")));
+}
+
+
+bool Isolate::IsSyntaxErrorObject(Handle<Object> obj) {
+  return IsTypeObject(obj,
+    factory()->InternalizeOneByteString(STATIC_ASCII_VECTOR("$SyntaxError")));
+}
+
+
+bool Isolate::IsTypeObject(Handle<Object> obj, Handle<String> key) {

[vsevik, 2014/06/06 16:12:01]

IsObjectOfType

[vsevik, 2014/06/06 16:12:01]

key -> js_builtin_key

   if (!obj->IsJSObject()) return false;
 
-  Handle<String> error_key =
-      factory()->InternalizeOneByteString(STATIC_ASCII_VECTOR("$Error"));
-  Handle<Object> error_constructor = Object::GetProperty(
-      js_builtins_object(), error_key).ToHandleChecked();
+  Handle<Object> constructor = Object::GetProperty(
+      js_builtins_object(), key).ToHandleChecked();
 
   DisallowHeapAllocation no_gc;
   for (Object* prototype = *obj; !prototype->IsNull();
        prototype = prototype->GetPrototype(this)) {
     if (!prototype->IsJSObject()) return false;
     if (JSObject::cast(prototype)->map()->constructor() ==
-        *error_constructor) {
+        *constructor) {
       return true;
     }
   }
   return false;
 }
 
 static int fatal_exception_depth = 0;
 
 void Isolate::DoThrow(Object* exception, MessageLocation* location) {
   ASSERT(!has_pending_exception());
 
   HandleScope scope(this);
   Handle<Object> exception_handle(exception, this);
 
   // Determine reporting and whether the exception is caught externally.
   bool catchable_by_javascript = is_catchable_by_javascript(exception);
   bool can_be_caught_externally = false;
   bool should_report_exception =
       ShouldReportException(&can_be_caught_externally, catchable_by_javascript);
   bool report_exception = catchable_by_javascript && should_report_exception;
   bool try_catch_needs_message =
       can_be_caught_externally && try_catch_handler()->capture_message_ &&
       !thread_local_top()->rethrowing_message_;
   bool bootstrapping = bootstrapper()->IsActive();
 
   thread_local_top()->rethrowing_message_ = false;
 
+  // notify debugger of SyntaxError
+  if (location != NULL && IsSyntaxErrorObject(exception_handle)) {
+    debugger_->OnSyntaxError(location->script());
+  }
+
   // Notify debugger of exception.
   if (catchable_by_javascript) {
     debugger_->OnException(
         exception_handle, report_exception, factory()->undefined_value());
   }
 
   // Generate the message if required.
   if (report_exception || try_catch_needs_message) {
     MessageLocation potential_computed_location;
     if (location == NULL) {
@@ skipping 1205 matching lines @@
   handle_scope_implementer()->IncrementCallDepth();
   if (run_microtasks) Execution::RunMicrotasks(this);
   for (int i = 0; i < call_completed_callbacks_.length(); i++) {
     call_completed_callbacks_.at(i)();
   }
   handle_scope_implementer()->DecrementCallDepth();
 }
 
 
 } }  // namespace v8::internal