Chromium Code Reviews
Help | Chromium Project | Sign in
(98)

Issue 26355003: Fix warnings and errors detected by dart2js. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 year, 10 months ago by Siggi Cherem (dart-lang)
Modified:
1 year, 10 months ago
Reviewers:
terry, John Messerly
CC:
reviews_dartlang.org, web-ui-dev+reviews_dartlang.org
Base URL:
git@github.com:dart-lang/web-ui.git@master
Visibility:
Public.

Description

Fix warnings and errors in 'web_ui' detected by dart2js. Addresses bug: https://code.google.com/p/dart/issues/detail?id=12526 R=jmesserly@google.com Committed: https://github.com/dart-lang/web-ui/commit/44c3c81

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -5 lines) Patch
M lib/observe.dart View 1 chunk +1 line, -1 line 0 comments Download
M lib/observe/list.dart View 1 chunk +0 lines, -1 line 0 comments Download
M lib/web_ui.dart View 1 chunk +1 line, -1 line 0 comments Download
M pubspec.yaml View 1 chunk +1 line, -1 line 0 comments Download
M test/observe_test.dart View 1 chunk +1 line, -1 line 0 comments Download
Trybot results:
Project "None" does not have a commit queue.

Messages

Total messages: 3 (0 generated)
Siggi Cherem (dart-lang)
1 year, 10 months ago (2013-10-07 21:43:28 UTC) #1
John Messerly
lgtm
1 year, 10 months ago (2013-10-07 22:31:38 UTC) #2
Siggi Cherem (dart-lang)
1 year, 10 months ago (2013-10-07 22:44:11 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r44c3c81 (presubmit successful).
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld a4c4f45