Refactor budget computation to be more tuneable.

chrome/browser/budget_service/budget_manager_unittest.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <stdint.h>
 #include <string>
 
 #include "base/memory/ptr_util.h"
 #include "base/run_loop.h"
 #include "base/test/histogram_tester.h"
@@ skipping 97 matching lines @@
  private:
   content::TestBrowserThreadBundle thread_bundle_;
   TestingProfile profile_;
   base::HistogramTester histogram_tester_;
   url::Origin origin_;
 
   DISALLOW_COPY_AND_ASSIGN(BudgetManagerTest);
 };
 
 TEST_F(BudgetManagerTest, GetBudgetConsumedOverTime) {
-  // Set initial SES. The first time we try to spend budget, the
-  // engagement award will be granted which is 48.0.
+  // Set initial SES. The first time we try to spend budget, the engagement
+  // award will be granted which is 23.04. (kTestSES * maxDaily / maxSES)
   SetSiteEngagementScore(kTestSES);
   const blink::mojom::BudgetOperationType type =
       blink::mojom::BudgetOperationType::SILENT_PUSH;
 
-  // Spend for 24 silent push messages. This should consume all the original
+  // Spend for 11 silent push messages. This should consume all the original
   // budget grant.
-  for (int i = 0; i < 24; i++) {
+  for (int i = 0; i < 11; i++) {
     ASSERT_TRUE(GetBudget());
     ASSERT_TRUE(ReserveBudget(type));
   }
 
   // Try to send one final silent push. The origin should be out of budget.
   ASSERT_TRUE(GetBudget());
   ASSERT_FALSE(ReserveBudget(type));
 
-  // Try to consume for the 24 messages reserved.
-  for (int i = 0; i < 24; i++)
+  // Try to consume for the 11 messages reserved.
+  for (int i = 0; i < 11; i++)
     ASSERT_TRUE(ConsumeBudget(type));
 
   // The next consume should fail, since there is no reservation or budget
   // available.
   ASSERT_FALSE(ConsumeBudget(type));
 
   // Check the the UMA recorded for the Reserve calls matches the operations
   // that were executed.
   std::vector<base::Bucket> buckets =
       histogram_tester()->GetAllSamples("Blink.BudgetAPI.Reserve");
   ASSERT_EQ(2U, buckets.size());
   // 1 failed reserve call.
   EXPECT_EQ(0, buckets[0].min);
   EXPECT_EQ(1, buckets[0].count);
-  // 24 successful reserve calls.
+  // 11 successful reserve calls.
   EXPECT_EQ(1, buckets[1].min);
-  EXPECT_EQ(24, buckets[1].count);
+  EXPECT_EQ(11, buckets[1].count);
 
   // Check that the UMA recorded for the GetBudget calls matches the operations
   // that were executed.
   buckets = histogram_tester()->GetAllSamples("Blink.BudgetAPI.QueryBudget");
 
   int num_samples = 0;
   for (const base::Bucket& bucket : buckets)
     num_samples += bucket.count;
-  EXPECT_EQ(25, num_samples);
+  EXPECT_EQ(12, num_samples);
 }
 
 TEST_F(BudgetManagerTest, TestInsecureOrigin) {
   const blink::mojom::BudgetOperationType type =
       blink::mojom::BudgetOperationType::SILENT_PUSH;
   SetOrigin(url::Origin(GURL("http://example.com")));
   SetSiteEngagementScore(kTestSES);
 
   // Methods on the BudgetManager should only be allowed for secure origins.
   ASSERT_FALSE(ReserveBudget(type));
   ASSERT_EQ(blink::mojom::BudgetServiceErrorType::NOT_SUPPORTED, error_);
   ASSERT_FALSE(ConsumeBudget(type));
 }
 
 TEST_F(BudgetManagerTest, TestUniqueOrigin) {
   const blink::mojom::BudgetOperationType type =
       blink::mojom::BudgetOperationType::SILENT_PUSH;
   SetOrigin(url::Origin(GURL("file://example.com:443/etc/passwd")));
 
   // Methods on the BudgetManager should not be allowed for unique origins.
   ASSERT_FALSE(ReserveBudget(type));
   ASSERT_EQ(blink::mojom::BudgetServiceErrorType::NOT_SUPPORTED, error_);
   ASSERT_FALSE(ConsumeBudget(type));
 }