content/browser/browser_plugin/browser_plugin_guest.cc - Issue 261013005: BrowserPlugin: Move CreateGuest to chrome

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/browser_plugin/browser_plugin_guest.cc

Issue 261013005: BrowserPlugin: Move CreateGuest to chrome (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@guestview_manager_simplify_api

Patch Set: Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/browser_plugin/browser_plugin_embedder.cc ('k') | content/browser/browser_plugin/browser_plugin_guest_manager.h » ('j') | content/browser/browser_plugin/browser_plugin_guest_manager.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/browser_plugin/browser_plugin_guest.cc

diff --git a/content/browser/browser_plugin/browser_plugin_guest.cc b/content/browser/browser_plugin/browser_plugin_guest.cc

index ad2e1f3beca21f9d28cfb03c99bf91b1361668ef..ce742f17809ad815e25870756b381c3f5d9591fb 100644

--- a/content/browser/browser_plugin/browser_plugin_guest.cc

+++ b/content/browser/browser_plugin/browser_plugin_guest.cc

@@ -325,10 +325,13 @@ BrowserPluginGuest* BrowserPluginGuest::CreateNewGuestWindow(

// embedder exposes the same API for this guest as its opener.

scoped_ptr<base::DictionaryValue> extra_params(

extra_attach_params_->DeepCopy());

+ StorageInfo storage_info;

+ storage_info.partition_id = attach_params.storage_partition_id;

+ storage_info.persist = attach_params.persist_storage;

BrowserPluginGuest* new_guest =

guest_manager->CreateGuest(GetWebContents()->GetSiteInstance(),

instance_id,

- attach_params,

+ storage_info,

extra_params.Pass());

if (new_guest->delegate_)

new_guest->delegate_->SetOpener(GetWebContents());