BrowserPlugin: Move CreateGuest to chrome

content/public/browser/web_contents.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_PUBLIC_BROWSER_WEB_CONTENTS_H_
 #define CONTENT_PUBLIC_BROWSER_WEB_CONTENTS_H_
 
 #include <set>
 
 #include "base/basictypes.h"
@@ skipping 12 matching lines @@
 #include "third_party/skia/include/core/SkColor.h"
 #include "ui/base/window_open_disposition.h"
 #include "ui/gfx/native_widget_types.h"
 #include "ui/gfx/size.h"
 
 #if defined(OS_ANDROID)
 #include "base/android/scoped_java_ref.h"
 #endif
 
 namespace base {
+class DictionaryValue;
 class TimeTicks;
 }
 
 namespace blink {
 struct WebFindOptions;
 }
 
 namespace gfx {
 class Rect;
 class Size;
@@ skipping 37 matching lines @@
 // NavigationController belongs to one WebContents. The NavigationController can
 // be obtained from GetController(), and is used to load URLs into the
 // WebContents, navigate it backwards/forwards, etc. See navigation_controller.h
 // for more details.
 class WebContents : public PageNavigator,
                     public IPC::Sender,
                     public base::SupportsUserData {
  public:
   struct CONTENT_EXPORT CreateParams {
     explicit CreateParams(BrowserContext* context);
+    virtual ~CreateParams();
     CreateParams(BrowserContext* context, SiteInstance* site);
 
     BrowserContext* browser_context;
 
     // Specifying a SiteInstance here is optional.  It can be set to avoid an
     // extra process swap if the first navigation is expected to require a
     // privileged process.
     SiteInstance* site_instance;
 
     WebContents* opener;
     int routing_id;
     int main_frame_routing_id;
 
     // Initial size of the new WebContent's view. Can be (0, 0) if not needed.
     gfx::Size initial_size;
 
     // True if the contents should be initially hidden.
     bool initially_hidden;
 
+    // The guest instance to use.

[lazyboy, 2014/05/02 19:52:52]

Need more description about guest since it is in WebContents. Also say when we
don't care about Browser Plugins, set to 0.

[Fady Samuel, 2014/05/06 20:02:48]

Done.

+    int guest_instance_id;
+
+    // TODO(fsmauel): This is temporary. Remove this when WebContents is
+    // created from the chrome layer.
+    scoped_ptr<base::DictionaryValue> guest_extra_params;
+
     // Used to specify the location context which display the new view should
     // belong. This can be NULL if not needed.
     gfx::NativeView context;
   };
 
   // Creates a new WebContents.
   CONTENT_EXPORT static WebContents* Create(const CreateParams& params);
 
   // Similar to Create() above but should be used when you need to prepopulate
   // the SessionStorageNamespaceMap of the WebContents. This can happen if
@@ skipping 430 matching lines @@
 
  private:
   // This interface should only be implemented inside content.
   friend class WebContentsImpl;
   WebContents() {}
 };
 
 }  // namespace content
 
 #endif  // CONTENT_PUBLIC_BROWSER_WEB_CONTENTS_H_