sandbox/linux/seccomp-bpf/syscall_unittest.cc - Issue 260793003: [MIPS] Add seccomp bpf support

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sandbox/linux/seccomp-bpf/syscall_unittest.cc

Issue 260793003: [MIPS] Add seccomp bpf support (Closed) Base URL: https://git.chromium.org/git/chromium/src.git@master

Patch Set: Update per code review Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: sandbox/linux/seccomp-bpf/syscall_unittest.cc

diff --git a/sandbox/linux/seccomp-bpf/syscall_unittest.cc b/sandbox/linux/seccomp-bpf/syscall_unittest.cc

index 4e142f42376e1809d48b93cab425b02a26ae71f5..3d6866ef6b5df4387352b9612e655ac33d2c0ba7 100644

--- a/sandbox/linux/seccomp-bpf/syscall_unittest.cc

+++ b/sandbox/linux/seccomp-bpf/syscall_unittest.cc

@@ -54,6 +54,9 @@ TEST(Syscall, WellKnownEntryPoint) {

#else

EXPECT_EQ(0xEF000000u, ((uint32_t*)Syscall::Call(-1))[-1]); // SVC 0

#endif

+#elif defined(__mips__)

+ // Opcode for MIPS sycall is in the lower 16-bits

+ EXPECT_EQ(0x0cu, (((uint32_t*)Syscall::Call(-1))[-1]) & 0x0000FFFF);

#else

#warning Incomplete test case; need port for target platform

#endif