android_webview/browser/icon_helper.cc - Issue 25878003: [Android WebView] Add an API to control favicon loading.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: android_webview/browser/icon_helper.cc

Issue 25878003: [Android WebView] Add an API to control favicon loading. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « android_webview/browser/icon_helper.h ('k') | android_webview/java/src/org/chromium/android_webview/AwContents.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: android_webview/browser/icon_helper.cc

diff --git a/android_webview/browser/icon_helper.cc b/android_webview/browser/icon_helper.cc

index 80233fca2359f0c38207b9eceed15fe7c7572b82..e227532626ee1ecb3fbf9f69ce35ebff3a3fb898 100644

--- a/android_webview/browser/icon_helper.cc

+++ b/android_webview/browser/icon_helper.cc

@@ -60,9 +60,7 @@ void IconHelper::DidUpdateFaviconURL(int32 page_id,

switch(i->icon_type) {

case content::FaviconURL::FAVICON:

- // TODO(acleung): only fetch the URL if favicon downloading is enabled.

- // (currently that is, the app has called WebIconDatabase.open()

- // but we should decouple that setting via a boolean setting)

+ if (listener_ && !listener_->ShouldDownloadFavicon(i->icon_url)) break;

web_contents()->DownloadImage(i->icon_url,

true, // Is a favicon

0, // No maximum size

« no previous file with comments | « android_webview/browser/icon_helper.h ('k') | android_webview/java/src/org/chromium/android_webview/AwContents.java » ('j') | no next file with comments »