Issue 25878003: [Android WebView] Add an API to control favicon loading.

Issue 25878003: [Android WebView] Add an API to control favicon loading. (Closed)

Created:
7 years, 2 months ago by benm (inactive)

Modified:
7 years, 2 months ago

Reviewers:
joth, Kristian Monsen

CC:
chromium-reviews, android-webview-reviews_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

[Android WebView] Add an API to control favicon loading. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=227129

Patch Set 4 : Fix joth's comment #

Patch Set 5 : move off BrowserContext #

Patch Set 7 : #

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+19 lines, -3 lines)			Patch
M	android_webview/browser/icon_helper.h	View	1 2 3 4	1 chunk	+1 line, -0 lines	0 comments	Download
M	android_webview/browser/icon_helper.cc	View	1 2 3 4 5 6	1 chunk	+1 line, -3 lines	0 comments	Download
M	android_webview/java/src/org/chromium/android_webview/AwContents.java	View	1 4	2 chunks	+5 lines, -0 lines	0 comments	Download
M	android_webview/javatests/src/org/chromium/android_webview/test/AwTestBase.java	View	1 2 3 4 5 6	1 chunk	+1 line, -0 lines	0 comments	Download
M	android_webview/native/aw_contents.h	View	1 2 3 4	1 chunk	+1 line, -0 lines	0 comments	Download
M	android_webview/native/aw_contents.cc	View	1 2 3 4	3 chunks	+10 lines, -0 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

joth

lgtm https://chromiumcodereview.appspot.com/25878003/diff/10001/android_webview/java/src/org/chromium/android_webview/AwContents.java File android_webview/java/src/org/chromium/android_webview/AwContents.java (right): https://chromiumcodereview.appspot.com/25878003/diff/10001/android_webview/java/src/org/chromium/android_webview/AwContents.java#newcode695 android_webview/java/src/org/chromium/android_webview/AwContents.java:695: public static void setShouldDownloadFavicons() { make this package ...

7 years, 2 months ago (2013-10-04 14:34:14 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/benm@chromium.org/25878003/29001

7 years, 2 months ago (2013-10-04 16:54:50 UTC) #4

commit-bot: I haz the power

Retried try job too often on win_rel for step(s) browser_tests, chrome_frame_net_tests, chrome_frame_tests, chrome_frame_unittests, content_browsertests, mini_installer_test, ...

7 years, 2 months ago (2013-10-04 20:17:23 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/benm@chromium.org/25878003/29001

7 years, 2 months ago (2013-10-04 20:37:07 UTC) #6

Message was sent while issue was closed.

Change committed as 227129

Expand Messages | Collapse Messages