Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Unified Diff: content/browser/browser_plugin/test_browser_plugin_guest_manager.cc

Issue 258373002: Towards moving guest management to chrome: Introduce GuestViewManager (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Merge with ToT Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/browser_plugin/test_browser_plugin_guest_manager.cc
diff --git a/content/browser/browser_plugin/test_browser_plugin_guest_manager.cc b/content/browser/browser_plugin/test_browser_plugin_guest_manager.cc
index 2d742880364c862bea538316dbcd4df2b683f89e..46a8bf014115920a83887c73e5bdd4be6f27ee89 100644
--- a/content/browser/browser_plugin/test_browser_plugin_guest_manager.cc
+++ b/content/browser/browser_plugin/test_browser_plugin_guest_manager.cc
@@ -9,7 +9,10 @@
namespace content {
-TestBrowserPluginGuestManager::TestBrowserPluginGuestManager() {
+TestBrowserPluginGuestManager::TestBrowserPluginGuestManager(
+ BrowserContext* context)
+ : BrowserPluginGuestManager(context),
+ last_guest_added_(NULL) {
}
TestBrowserPluginGuestManager::~TestBrowserPluginGuestManager() {
@@ -17,19 +20,21 @@ TestBrowserPluginGuestManager::~TestBrowserPluginGuestManager() {
void TestBrowserPluginGuestManager::AddGuest(
int instance_id,
- WebContentsImpl* guest_web_contents) {
+ WebContents* guest_web_contents) {
BrowserPluginGuestManager::AddGuest(instance_id, guest_web_contents);
- if (message_loop_runner_)
+ last_guest_added_ = guest_web_contents;
+ if (message_loop_runner_.get())
message_loop_runner_->Quit();
}
-void TestBrowserPluginGuestManager::WaitForGuestAdded() {
+WebContents* TestBrowserPluginGuestManager::WaitForGuestAdded() {
// Check if guests were already created.
- if (guest_web_contents_by_instance_id_.size() > 0)
- return;
+ if (last_guest_added_)
lazyboy 2014/05/01 20:06:59 Set last_guest_added_ = NULL after returning the v
Fady Samuel 2014/05/01 21:05:28 Done.
+ return last_guest_added_;
// Wait otherwise.
message_loop_runner_ = new MessageLoopRunner();
message_loop_runner_->Run();
+ return last_guest_added_;
}
} // namespace content

Powered by Google App Engine
This is Rietveld 408576698