Towards moving guest management to chrome: Introduce GuestViewManager

chrome/browser/guest_view/guest_view_base.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_GUEST_VIEW_GUEST_VIEW_BASE_H_
 #define CHROME_BROWSER_GUEST_VIEW_GUEST_VIEW_BASE_H_
 
 #include <queue>
 
 #include "base/memory/weak_ptr.h"
@@ skipping 29 matching lines @@
   template <typename T>
   T* As() {
     if (!strcmp(GetViewType(), T::Type)) {
       return static_cast<T*>(this);
     }
     return NULL;
   }
 
   static GuestViewBase* Create(content::WebContents* guest_web_contents,
                                const std::string& embedder_extension_id,
-                               const std::string& view_type);
+                               const std::string& view_type,
+                               const base::WeakPtr<GuestViewBase>& opener);
 
   static GuestViewBase* FromWebContents(content::WebContents* web_contents);
 
   static GuestViewBase* From(int embedder_process_id, int instance_id);
 
   // For GuestViewBases, we create special guest processes, which host the
   // tag content separately from the main application that embeds the tag.
   // A GuestViewBase can specify both the partition name and whether the storage
   // for that partition should be persisted. Each tag gets a SiteInstance with
   // a specially formatted URL, based on the application it is hosted by and
   // the partition requested by it. The format for that URL is:
   // chrome-guest://partition_domain/persist?partition_name
   static bool GetGuestPartitionConfigForSite(const GURL& site,
                                              std::string* partition_domain,
                                              std::string* partition_name,
                                              bool* in_memory);
 
   // By default, JavaScript and images are enabled in guest content.
   static void GetDefaultContentSettingRules(RendererContentSettingRules* rules,
                                             bool incognito);
 
   virtual const char* GetViewType() const = 0;
 
+  base::WeakPtr<GuestViewBase> AsWeakPtr();
+
   virtual void Attach(content::WebContents* embedder_web_contents,
                       const base::DictionaryValue& args);
 
   content::WebContents* embedder_web_contents() const {
     return embedder_web_contents_;
   }
 
   // Returns the guest WebContents.
   content::WebContents* guest_web_contents() const {
     return guest_web_contents_;
@@ skipping 15 matching lines @@
 
   // Returns whether this GuestView is embedded in an extension/app.
   bool in_extension() const { return !embedder_extension_id_.empty(); }
 
   // Returns the user browser context of the embedder.
   content::BrowserContext* browser_context() const { return browser_context_; }
 
   // Returns the embedder's process ID.
   int embedder_render_process_id() const { return embedder_render_process_id_; }
 
+  // BrowserPluginGuestDelegate implementation.
+  virtual content::WebContents* GetOpener() const OVERRIDE;
+  virtual void SetOpener(content::WebContents* opener) OVERRIDE;
+
  protected:
   GuestViewBase(content::WebContents* guest_web_contents,
-                const std::string& embedder_extension_id);
+                const std::string& embedder_extension_id,
+                const base::WeakPtr<GuestViewBase>& opener);
   virtual ~GuestViewBase();
 
   // Dispatches an event |event_name| to the embedder with the |event| fields.
   void DispatchEvent(Event* event);
 
  private:
   void SendQueuedEvents();
 
   content::WebContents* const guest_web_contents_;
   content::WebContents* embedder_web_contents_;
   const std::string embedder_extension_id_;
   int embedder_render_process_id_;
   content::BrowserContext* const browser_context_;
   // |guest_instance_id_| is a profile-wide unique identifier for a guest
   // WebContents.
   const int guest_instance_id_;
   // |view_instance_id_| is an identifier that's unique within a particular
   // embedder RenderViewHost for a particular <*view> instance.
   int view_instance_id_;
 
   // This is a queue of Events that are destined to be sent to the embedder once
   // the guest is attached to a particular embedder.
   std::deque<linked_ptr<Event> > pending_events_;
 
+  // Returns a WeakPtr to this GuestView.

[lazyboy, 2014/05/01 20:06:59]

1) this is a member so doc shouldn't start /w "returns ..."
2) This is not the same opener WebContents as this GuestView's WebContents,
right?
This probably should say just 
// The opener guest view.
base::WeakPtr<GuestViewBase> opener_;

[Fady Samuel, 2014/05/01 21:05:28]

Done.

+  base::WeakPtr<GuestViewBase> opener_;
+
   // This is used to ensure pending tasks will not fire after this object is
   // destroyed.
   base::WeakPtrFactory<GuestViewBase> weak_ptr_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(GuestViewBase);
 };
 
 #endif  // CHROME_BROWSER_GUEST_VIEW_GUEST_VIEW_BASE_H_