ash/wm/overview/window_overview.cc - Issue 257763008: Added a11y alert on entering overview mode

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ash/wm/overview/window_overview.cc

Issue 257763008: Added a11y alert on entering overview mode (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixed issues discovered by reviewers Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ash/wm/overview/window_overview.cc

diff --git a/ash/wm/overview/window_overview.cc b/ash/wm/overview/window_overview.cc

index ec5efc76a6bc8036a206850c48ed95be0ac1607e..424b82e833614e90df1c70c71a7fa51ba67e3c88 100644

--- a/ash/wm/overview/window_overview.cc

+++ b/ash/wm/overview/window_overview.cc

@@ -6,6 +6,7 @@

#include <algorithm>

+#include "ash/accessibility_delegate.h"

#include "ash/metrics/user_metrics_recorder.h"

#include "ash/screen_util.h"

#include "ash/shell.h"

@@ -150,6 +151,10 @@ WindowOverview::WindowOverview(WindowSelector* window_selector,

shell->GetScreen()->AddObserver(this);

shell->metrics()->RecordUserMetricsAction(UMA_WINDOW_OVERVIEW);

HideAndTrackNonOverviewWindows();

+ // Send an a11y alert only if the overview was activated by the user.

+ if (window_selector_->mode() == WindowSelector::OVERVIEW)

flackr 2014/04/29 14:21:16 nit: need braces { } since the code block is multi

Nina 2014/04/29 14:24:34 Done.

+ shell->accessibility_delegate()->TriggerAccessibilityAlert(

+ A11Y_ALERT_WINDOW_OVERVIEW_MODE_ENTERED);

}

WindowOverview::~WindowOverview() {

« no previous file with comments | « ash/accessibility_delegate.h ('k') | ash/wm/overview/window_selector_unittest.cc » ('j') | no next file with comments »