Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 25718002: Only fold polymorphic into monomorphic load if all load from either receiver or same prototype. (Closed)

Created:
7 years, 2 months ago by Toon Verwaest
Modified:
7 years, 2 months ago
Reviewers:
Jakob Kummerow
CC:
v8-dev
Visibility:
Public.

Description

Only fold polymorphic into monomorphic load if all load from either receiver or same prototype. R=jkummerow@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=17078

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -14 lines) Patch
M src/hydrogen.cc View 1 chunk +5 lines, -1 line 0 comments Download
A + test/mjsunit/regress/regress-polymorphic-load.js View 1 1 chunk +11 lines, -13 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Toon Verwaest
PTAL
7 years, 2 months ago (2013-10-02 13:08:19 UTC) #1
Jakob Kummerow
LGTM
7 years, 2 months ago (2013-10-02 13:10:18 UTC) #2
Toon Verwaest
7 years, 2 months ago (2013-10-02 13:25:37 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r17078.

Powered by Google App Engine
This is Rietveld 408576698