Issue 25702008: Enable weak embedded objects in optimized code with a fix for heap verifier.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 25702008: Enable weak embedded objects in optimized code with a fix for heap verifier. (Closed)

Created:
7 years, 2 months ago by ulan

Modified:
7 years, 2 months ago

Reviewers:
Michael Starzinger

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Enable weak embedded objects in optimized code with a fix for heap verifier. BUG=v8:2073 R=mstarzinger@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=17141

Patch Set 2 : Remove ifdef DEBUG #

Total comments: 2

Patch Set 3 : Add comment #

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -1 line)			Patch
M	src/flag-definitions.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/heap.cc	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	src/objects.h	View	1 2	1 chunk	+9 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Michael Starzinger

LGTM. https://codereview.chromium.org/25702008/diff/4001/src/objects.h File src/objects.h (right): https://codereview.chromium.org/25702008/diff/4001/src/objects.h#newcode4004 src/objects.h:4004: void Zap(Object* value) { nit: Maybe add a ...

7 years, 2 months ago (2013-10-04 11:33:40 UTC) #2

ulan

https://codereview.chromium.org/25702008/diff/4001/src/objects.h File src/objects.h (right): https://codereview.chromium.org/25702008/diff/4001/src/objects.h#newcode4004 src/objects.h:4004: void Zap(Object* value) { On 2013/10/04 11:33:40, Michael Starzinger ...

7 years, 2 months ago (2013-10-04 11:37:17 UTC) #3