Return unicode commit hashes in checkout.GitCheckout

tests/checkout_test.py

Index: tests/checkout_test.py
===================================================================
--- tests/checkout_test.py	(revision 226480)
+++ tests/checkout_test.py	(working copy)
@@ -284,7 +284,9 @@
       self.FAKE_REPOS.svn_dirty = True
 
     self.assertEquals(root, co.project_path)
-    self.assertEquals(self.previous_log['revision'], co.prepare(None))
+    svn_rev = co.prepare(None)
+    self.assertEquals(int, type(svn_rev))
+    self.assertEquals(self.previous_log['revision'], svn_rev)
     self.assertEquals('pouet', co.get_settings('bar'))
     self.assertTree(self.get_trunk(False), root)
     patches = self.get_patches()
@@ -377,7 +379,9 @@
       self.FAKE_REPOS.git_dirty = True
 
     self.assertEquals(root, co.project_path)
-    self.assertEquals(self.previous_log['revision'], co.prepare(None))
+    git_rev = co.prepare(None)
+    self.assertEquals(unicode, type(git_rev))

[iannucci, 2013/10/02 18:24:36]

hmm... can't we just change the expected return type to str? Since it's actually
hex-encoded binary, I don't see any benefit to casting to unicode (unless it's
expecting to be able to get a refname, but even then, I'm pretty sure git
doesn't support unicode refs).

[rmistry, 2013/10/02 19:02:13]

We can, it will need a few changes in the CQ.
Since svn revs are expected to be ints I figured it would be ok if git revs are
expected to be unicodes, but if you prefer the other approach then that SGTM.
CL coming soon..

+    self.assertEquals(self.previous_log['revision'], git_rev)
     self.assertEquals('pouet', co.get_settings('bar'))
     self.assertTree(self.get_trunk(False), root)
     patches = self.get_patches()