chrome/browser/ui/webui/metrics_handler.cc - Issue 256763004: Remove WebUI NTP on Android.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/ui/webui/metrics_handler.cc

Issue 256763004: Remove WebUI NTP on Android. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Ted's nit Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "chrome/browser/ui/webui/metrics_handler.h"	5 #include "chrome/browser/ui/webui/metrics_handler.h"

6	6

7 #include "base/bind.h"	7 #include "base/bind.h"

8 #include "base/bind_helpers.h"	8 #include "base/bind_helpers.h"

9 #include "base/logging.h"	9 #include "base/logging.h"

10 #include "base/metrics/histogram.h"	10 #include "base/metrics/histogram.h"

(...skipping 98 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
109 } else {	109 } else {

110 NOTREACHED();	110 NOTREACHED();

111 }	111 }

112 content::NotificationService::current()->Notify(	112 content::NotificationService::current()->Notify(

113 chrome::NOTIFICATION_METRIC_EVENT_DURATION,	113 chrome::NOTIFICATION_METRIC_EVENT_DURATION,

114 content::Source<WebContents>(tab),	114 content::Source<WebContents>(tab),

115 content::Details<MetricEventDurationDetails>(&details));	115 content::Details<MetricEventDurationDetails>(&details));

116 }	116 }

117	117

118 void MetricsHandler::HandleLogMouseover(const base::ListValue* args) {	118 void MetricsHandler::HandleLogMouseover(const base::ListValue* args) {

	119 #if !defined(OS_ANDROID)
	Nico 2014/04/25 20:22:04 Do you need this? If this function isn't called, t Do you need this? If this function isn't called, the linker will strip it. If it is called, you probably want this code. (?) aurimas (slooooooooow) 2014/04/25 21:23:38 It actually fails to compile. This function get re Show quoted text On 2014/04/25 20:22:04, Nico wrote: > Do you need this? If this function isn't called, the linker will strip it. If it > is called, you probably want this code. (?) It actually fails to compile. This function get registered as a handler in MetricsHandler::RegisterMessages. Ideally both MetricsHandler::HandleLogEventTime and MetricsHandler::HandleLogMouseover would move to a new class called NewTabHanlder instead of living in this generic metrics_handler.cc.
119 NTPUserDataLogger::GetOrCreateFromWebContents(	120 NTPUserDataLogger::GetOrCreateFromWebContents(

120 web_ui()->GetWebContents())->LogEvent(NTP_MOUSEOVER);	121 web_ui()->GetWebContents())->LogEvent(NTP_MOUSEOVER);

	122 #endif // !defined(OS_ANDROID)

121 }	123 }

OLD	NEW