Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(341)

Issue 2567293003: Add a macro for SharedMemory::Share (Closed)

Created:
4 years ago by hajimehoshi
Modified:
4 years ago
CC:
chromium-reviews, gavinp+memory_chromium.org, vmpstr+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add a macro for SharedMemory::Share SharedMemory::Share was introduced at crrev.com/2555483002 only on Mac and not other platforms. This CL adds a macro to SharedMemory::Share declaration to clarily that the function Share is available only on Mac. BUG=671228 TEST=n/a Committed: https://crrev.com/73172f9e94e5af7e23867506c9e5a9d6bc99c703 Cr-Commit-Position: refs/heads/master@{#438434}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M base/memory/shared_memory.h View 1 chunk +2 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 15 (9 generated)
hajimehoshi
PTAL
4 years ago (2016-12-13 07:29:37 UTC) #4
Mark Mentovai
LGTM
4 years ago (2016-12-13 15:01:56 UTC) #7
lawrencewu
lgtm
4 years ago (2016-12-13 15:30:25 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2567293003/1
4 years ago (2016-12-14 04:54:06 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-14 04:58:23 UTC) #13
commit-bot: I haz the power
4 years ago (2016-12-14 04:59:56 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/73172f9e94e5af7e23867506c9e5a9d6bc99c703
Cr-Commit-Position: refs/heads/master@{#438434}

Powered by Google App Engine
This is Rietveld 408576698