Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1203)

Issue 2565103002: Fix mismatched nullptr check for caret paint invalidation. (Closed)

Created:
4 years ago by wkorman
Modified:
4 years ago
Reviewers:
Xianzhu
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix mismatched nullptr check for caret paint invalidation. We moved to checking need-for-repaint and invalidating based on anchor node in http://crrev.com/2401363003 but we incorrectly left null-checking based on non-anchor node. BUG=663319 Committed: https://crrev.com/05b6f4be7e2e45c518441e2cf546d4472ee06fcb Cr-Commit-Position: refs/heads/master@{#437804}

Patch Set 1 #

Patch Set 2 : Sync to head and add test baselines. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1794 lines, -2 lines) Patch
A third_party/WebKit/LayoutTests/paint/invalidation/caret-contenteditable-content-after.html View 1 chunk +21 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/caret-contenteditable-content-after-expected.png View 1 Binary file 0 comments Download
A third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/caret-contenteditable-content-after-expected.txt View 1 1 chunk +295 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/platform/linux/virtual/spinvalidation/paint/invalidation/caret-contenteditable-content-after-expected.png View 1 Binary file 0 comments Download
A third_party/WebKit/LayoutTests/platform/linux/virtual/spinvalidation/paint/invalidation/caret-contenteditable-content-after-expected.txt View 1 1 chunk +295 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/caret-contenteditable-content-after-expected.png View 1 Binary file 0 comments Download
A third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/caret-contenteditable-content-after-expected.txt View 1 1 chunk +295 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/platform/mac/virtual/spinvalidation/paint/invalidation/caret-contenteditable-content-after-expected.png View 1 Binary file 0 comments Download
A third_party/WebKit/LayoutTests/platform/mac/virtual/spinvalidation/paint/invalidation/caret-contenteditable-content-after-expected.txt View 1 1 chunk +295 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/platform/win/paint/invalidation/caret-contenteditable-content-after-expected.png View 1 Binary file 0 comments Download
A third_party/WebKit/LayoutTests/platform/win/paint/invalidation/caret-contenteditable-content-after-expected.txt View 1 1 chunk +295 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/platform/win/virtual/spinvalidation/paint/invalidation/caret-contenteditable-content-after-expected.png View 1 Binary file 0 comments Download
A third_party/WebKit/LayoutTests/platform/win/virtual/spinvalidation/paint/invalidation/caret-contenteditable-content-after-expected.txt View 1 1 chunk +295 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/editing/FrameCaret.cpp View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 20 (13 generated)
wkorman
4 years ago (2016-12-10 01:19:46 UTC) #3
Xianzhu
lgtm
4 years ago (2016-12-10 02:06:02 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2565103002/20001
4 years ago (2016-12-10 18:41:44 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/196625)
4 years ago (2016-12-10 20:14:00 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2565103002/20001
4 years ago (2016-12-11 19:43:35 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-12-11 21:31:30 UTC) #18
commit-bot: I haz the power
4 years ago (2016-12-12 15:10:07 UTC) #20
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/05b6f4be7e2e45c518441e2cf546d4472ee06fcb
Cr-Commit-Position: refs/heads/master@{#437804}

Powered by Google App Engine
This is Rietveld 408576698