Description was changed from
==========
Fix mismatched null check for caret paint invalidation.
BUG=663319
==========
to
==========
Fix mismatched nullptr check for caret paint invalidation.
We moved to checking need-for-repaint and invalidating based
on anchor node in http://crrev.com/2401363003 but we
incorrectly left null-checking based on non-anchor node.
BUG=663319
==========
Dry run: Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/351985)
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/196625)
Description was changed from
==========
Fix mismatched nullptr check for caret paint invalidation.
We moved to checking need-for-repaint and invalidating based
on anchor node in http://crrev.com/2401363003 but we
incorrectly left null-checking based on non-anchor node.
BUG=663319
==========
to
==========
Fix mismatched nullptr check for caret paint invalidation.
We moved to checking need-for-repaint and invalidating based
on anchor node in http://crrev.com/2401363003 but we
incorrectly left null-checking based on non-anchor node.
BUG=663319
Review-Url: https://codereview.chromium.org/2565103002
==========
Description was changed from
==========
Fix mismatched nullptr check for caret paint invalidation.
We moved to checking need-for-repaint and invalidating based
on anchor node in http://crrev.com/2401363003 but we
incorrectly left null-checking based on non-anchor node.
BUG=663319
Review-Url: https://codereview.chromium.org/2565103002
==========
to
==========
Fix mismatched nullptr check for caret paint invalidation.
We moved to checking need-for-repaint and invalidating based
on anchor node in http://crrev.com/2401363003 but we
incorrectly left null-checking based on non-anchor node.
BUG=663319
Committed: https://crrev.com/05b6f4be7e2e45c518441e2cf546d4472ee06fcb
Cr-Commit-Position: refs/heads/master@{#437804}
==========
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/05b6f4be7e2e45c518441e2cf546d4472ee06fcb Cr-Commit-Position: refs/heads/master@{#437804}
Issue 2565103002: Fix mismatched nullptr check for caret paint invalidation.
(Closed)
Created 4 years ago by wkorman
Modified 4 years ago
Reviewers: Xianzhu
Base URL:
Comments: 0