Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(240)

Issue 2564123003: Face Detection: Use DetectedFace in FaceDetector.cpp iso DOMRect (Closed)

Created:
4 years ago by mcasas
Modified:
4 years ago
Reviewers:
haraken, xianglu
CC:
chromium-reviews, blink-reviews, jam, darin-cc_chromium.org, feature-media-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Face Detection: Use DetectedFace in FaceDetector.cpp iso DOMRect FaceDetector.detect() in ToT returns a sequence<DetectedObject>, but DetectedObject doesn't exist, and it should return DetectedFace instead according to the Spec. Also, DetectedFace is not used at the moment (FaceDetector goes around this issue by returning DOMRects directly). This CL sorts that out by returning DetectedFaces directly. BUG=673075 Committed: https://crrev.com/f1f5959ffc84ab6069c0a1b4cd0c784b24c996d2 Cr-Commit-Position: refs/heads/master@{#437794}

Patch Set 1 #

Messages

Total messages: 20 (13 generated)
mcasas
xianglu@ PTAL haraken@ RS plz (Don't mind the red android bots, it's unrelated https://crbug.com/653864)
4 years ago (2016-12-10 20:11:23 UTC) #4
haraken
LGTM
4 years ago (2016-12-11 00:55:39 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2564123003/1
4 years ago (2016-12-11 03:10:05 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/352092)
4 years ago (2016-12-11 06:04:02 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2564123003/1
4 years ago (2016-12-11 06:07:11 UTC) #15
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-11 17:41:33 UTC) #18
commit-bot: I haz the power
4 years ago (2016-12-12 15:09:49 UTC) #20
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f1f5959ffc84ab6069c0a1b4cd0c784b24c996d2
Cr-Commit-Position: refs/heads/master@{#437794}

Powered by Google App Engine
This is Rietveld 408576698