Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(274)

Issue 25634007: Update the protocol buffer library to use Int64 from the fixnum package (Closed)

Created:
7 years, 2 months ago by Søren Gjesse
Modified:
7 years, 2 months ago
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/dart-protobuf.git@master
Visibility:
Public.

Description

Update the protocol buffer library to use Int64 from the fixnum package The 64-bit integers in protocol buffer messages now use the Int64 object from the fixnum package for representing 64-bit integers instead of an 8-byte binary buffer. When generating JSON the 64-bit integers in the 53-bit range are written as integers. Larger integeres are still written as strings. R=sigmund@google.com BUG= Committed: https://github.com/dart-lang/protobuf/commit/822b4cf

Patch Set 1 #

Patch Set 2 : Minor fixes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+75 lines, -89 lines) Patch
M lib/coded_buffer_reader.dart View 1 3 chunks +20 lines, -29 lines 0 comments Download
M lib/coded_buffer_writer.dart View 1 3 chunks +15 lines, -21 lines 0 comments Download
M lib/generated_message.dart View 9 chunks +24 lines, -22 lines 0 comments Download
M lib/pb_list.dart View 2 chunks +4 lines, -4 lines 0 comments Download
M lib/protobuf.dart View 2 chunks +2 lines, -4 lines 0 comments Download
M lib/unknown_field_set.dart View 4 chunks +6 lines, -6 lines 0 comments Download
M pubspec.yaml View 1 chunk +4 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Søren Gjesse
This goes hand in hand with https://chromiumcodereview.appspot.com/25708003.
7 years, 2 months ago (2013-10-02 14:02:02 UTC) #1
Søren Gjesse
Friendly ping.
7 years, 2 months ago (2013-10-04 07:00:09 UTC) #2
Siggi Cherem (dart-lang)
lgtm sorry for the delay, I'm still catching up =)
7 years, 2 months ago (2013-10-04 17:58:03 UTC) #3
Søren Gjesse
7 years, 2 months ago (2013-10-07 06:51:28 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r822b4cf (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698