Implement the "needs-ice-restart" logic for SetConfiguration.

webrtc/p2p/base/jseptransport_unittest.cc

 /*
  *  Copyright 2011 The WebRTC Project Authors. All rights reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
@@ skipping 55 matching lines @@
 
 // Verifies that IceCredentialsChanged returns true when either ufrag or pwd
 // changed, and false in other cases.
 TEST_F(JsepTransportTest, TestIceCredentialsChanged) {
   EXPECT_TRUE(cricket::IceCredentialsChanged("u1", "p1", "u2", "p2"));
   EXPECT_TRUE(cricket::IceCredentialsChanged("u1", "p1", "u2", "p1"));
   EXPECT_TRUE(cricket::IceCredentialsChanged("u1", "p1", "u1", "p2"));
   EXPECT_FALSE(cricket::IceCredentialsChanged("u1", "p1", "u1", "p1"));
 }
 
+// Tests SetNeedsIceRestartFlag and NeedsIceRestart, ensuring NeedsIceRestart
+// only starts returning "false" once an ICE restart has been initiated.
+TEST_F(JsepTransportTest, NeedsIceRestart) {
+  // Do initial offer/answer so there's something to restart.
+  cricket::TransportDescription local_desc(kIceUfrag1, kIcePwd1);
+  cricket::TransportDescription remote_desc(kIceUfrag1, kIcePwd1);
+  ASSERT_TRUE(transport_->SetLocalTransportDescription(
+      local_desc, cricket::CA_OFFER, nullptr));
+  ASSERT_TRUE(transport_->SetRemoteTransportDescription(
+      remote_desc, cricket::CA_ANSWER, nullptr));
+
+  // Flag initially should be false.
+  EXPECT_FALSE(transport_->NeedsIceRestart());
+
+  // After setting flag, it should be true.
+  transport_->SetNeedsIceRestartFlag();
+  EXPECT_TRUE(transport_->NeedsIceRestart());
+
+  // Doing an identical offer/answer shouldn't clear the flag.
+  ASSERT_TRUE(transport_->SetLocalTransportDescription(
+      local_desc, cricket::CA_OFFER, nullptr));
+  ASSERT_TRUE(transport_->SetRemoteTransportDescription(
+      remote_desc, cricket::CA_ANSWER, nullptr));
+  EXPECT_TRUE(transport_->NeedsIceRestart());
+
+  // Doing an offer/answer that restarts ICE should clear the flag.
+  cricket::TransportDescription ice_restart_local_desc(kIceUfrag2, kIcePwd2);
+  cricket::TransportDescription ice_restart_remote_desc(kIceUfrag2, kIcePwd2);
+  ASSERT_TRUE(transport_->SetLocalTransportDescription(
+      ice_restart_local_desc, cricket::CA_OFFER, nullptr));
+  ASSERT_TRUE(transport_->SetRemoteTransportDescription(
+      ice_restart_remote_desc, cricket::CA_ANSWER, nullptr));
+  EXPECT_FALSE(transport_->NeedsIceRestart());
+}
+
 TEST_F(JsepTransportTest, TestGetStats) {
   EXPECT_TRUE(SetupChannel());
   cricket::TransportStats stats;
   EXPECT_TRUE(transport_->GetStats(&stats));
   // Note that this tests the behavior of a FakeTransportChannel.
   ASSERT_EQ(1U, stats.channel_stats.size());
   EXPECT_EQ(1, stats.channel_stats[0].component);
   // Set local transport description for FakeTransport before connecting.
   TransportDescription faketransport_desc(
       std::vector<std::string>(),
@@ skipping 177 matching lines @@
     remote_desc.connection_role = param.remote_role;
 
     ASSERT_TRUE(transport_->SetRemoteTransportDescription(
         remote_desc, param.remote_action, nullptr));
     ASSERT_TRUE(transport_->SetLocalTransportDescription(
         local_desc, param.local_action, nullptr));
     EXPECT_FALSE(
         transport_->NegotiateRole(param.local_action, &ssl_role, &error_desc));
   }
 }