Monkey patch httplib on python <=2.6.2 to make it work with 'requests' library.

Monkey patch httplib on python <=2.6.2 to make it work with 'requests' library.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=226325

[Vadim Sh., 2013-10-01 22:16:06]

Yeah...

I've looked through urllib3 code. I think if HTTP proxy is not actually used,
applying this patch would be enough to make it work on old python <= 2.6.2.

[M-A Ruel, 2013-10-01 22:44:02]

lgtm

https://codereview.chromium.org/25615002/diff/1/utils/net.py
File utils/net.py (right):

https://codereview.chromium.org/25615002/diff/1/utils/net.py#newcode36
utils/net.py:36: # 'requests' library (>= v2) accesses
'HTTPConnection._tunnel_host' attribute
I'd make it a docstring instead.

https://codereview.chromium.org/25615002/diff/1/utils/net.py#newcode39
utils/net.py:39: def monkey_patch_httplib():
Add a TODO remove once we don't have to support python 2.6 anymore.

[Vadim Sh., 2013-10-01 22:53:01]

https://codereview.chromium.org/25615002/diff/1/utils/net.py
File utils/net.py (right):

https://codereview.chromium.org/25615002/diff/1/utils/net.py#newcode36
utils/net.py:36: # 'requests' library (>= v2) accesses
'HTTPConnection._tunnel_host' attribute
On 2013/10/01 22:44:02, M-A Ruel wrote:
> I'd make it a docstring instead.

Done.

https://codereview.chromium.org/25615002/diff/1/utils/net.py#newcode39
utils/net.py:39: def monkey_patch_httplib():
On 2013/10/01 22:44:02, M-A Ruel wrote:
> Add a TODO remove once we don't have to support python 2.6 anymore.

Done.

[commit-bot: I haz the power, 2013-10-01 22:53:18]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/vadimsh@chromium.org/25615002/5001

[commit-bot: I haz the power, 2013-10-01 22:54:49]

Change committed as 226325