Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1329)

Unified Diff: content/public/android/java/src/org/chromium/content/browser/ChildProcessConnectionImpl.java

Issue 2560403002: android: Remove command line args from intent bundle (Closed)
Patch Set: delete more Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/public/android/java/src/org/chromium/content/app/ChildProcessServiceImpl.java ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/public/android/java/src/org/chromium/content/browser/ChildProcessConnectionImpl.java
diff --git a/content/public/android/java/src/org/chromium/content/browser/ChildProcessConnectionImpl.java b/content/public/android/java/src/org/chromium/content/browser/ChildProcessConnectionImpl.java
index 99032d485841e21fb8ac1c48891c446da628c949..4eb35a51ae3bf5c775008da3b1bba4d559a57999 100644
--- a/content/public/android/java/src/org/chromium/content/browser/ChildProcessConnectionImpl.java
+++ b/content/public/android/java/src/org/chromium/content/browser/ChildProcessConnectionImpl.java
@@ -130,9 +130,9 @@ public class ChildProcessConnectionImpl implements ChildProcessConnection {
try {
TraceEvent.begin("ChildProcessConnectionImpl.ChildServiceConnection.bind");
final Intent intent = createServiceBindIntent();
- if (commandLine != null) {
- intent.putExtra(ChildProcessConstants.EXTRA_COMMAND_LINE, commandLine);
- }
+ // Note, the intent may be saved and re-used by Android for re-launching the
+ // child service. Do not pass data that is different for each child; command
+ // line arguments for example.
if (mLinkerParams != null) {
mLinkerParams.addIntentExtras(intent);
}
« no previous file with comments | « content/public/android/java/src/org/chromium/content/app/ChildProcessServiceImpl.java ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698