Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2560313002:
flip nav timing 2 runtime flag to experimental (Closed)
DescriptionFlip nav timing 2 runtime flag to experimental.
This is to gather early feedback in canary, before we flip this to stable (for M57).
Link to Intent to ship.
https://groups.google.com/a/chromium.org/forum/#!topic/blink-
dev/AT7aqhPcNdw
BUG=672982
Committed: https://crrev.com/e7ddc344ea6721070a9f53e539ae9ba0a48b8c77
Cr-Commit-Position: refs/heads/master@{#438013}
Patch Set 1 #Patch Set 2 : sync #Patch Set 3 : sync #Messages
Total messages: 24 (12 generated)
sunjian@chromium.org changed reviewers: + panicker@chromium.org
Description was changed from ========== flip nav timing 2 runtime flag to experimental BUG=672982 ========== to ========== Flip nav timing 2 runtime flag to experimental. This is to gather early feedback in canary, before we flip this to stable (for M57). Link to Intent to ship. https://groups.google.com/a/chromium.org/forum/#!topic/blink- dev/AT7aqhPcNdw BUG=672982 ==========
LGTM.
panicker@chromium.org changed reviewers: + haraken@chromium.org
+Haraken for OWNERS
+Ilya as FYI.
\o/
LGTM
On 2016/12/10 13:01:39, haraken wrote: > LGTM Non-owner LGTM!
Patchset #2 (id:20001) has been deleted
The CQ bit was checked by sunjian@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from haraken@chromium.org, yoav@yoav.ws, panicker@chromium.org Link to the patchset: https://codereview.chromium.org/2560313002/#ps40001 (title: "sync")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by sunjian@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from haraken@chromium.org, yoav@yoav.ws, panicker@chromium.org Link to the patchset: https://codereview.chromium.org/2560313002/#ps60001 (title: "sync")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 60001, "attempt_start_ts": 1481592107572860,
"parent_rev": "02f02d115c165eed0b9ab2e1114def642d41df26", "commit_rev":
"77e2361644343e5873c0dbdb5b97bf8c10c37a73"}
Message was sent while issue was closed.
Description was changed from ========== Flip nav timing 2 runtime flag to experimental. This is to gather early feedback in canary, before we flip this to stable (for M57). Link to Intent to ship. https://groups.google.com/a/chromium.org/forum/#!topic/blink- dev/AT7aqhPcNdw BUG=672982 ========== to ========== Flip nav timing 2 runtime flag to experimental. This is to gather early feedback in canary, before we flip this to stable (for M57). Link to Intent to ship. https://groups.google.com/a/chromium.org/forum/#!topic/blink- dev/AT7aqhPcNdw BUG=672982 Review-Url: https://codereview.chromium.org/2560313002 ==========
Message was sent while issue was closed.
Committed patchset #3 (id:60001)
Message was sent while issue was closed.
Description was changed from ========== Flip nav timing 2 runtime flag to experimental. This is to gather early feedback in canary, before we flip this to stable (for M57). Link to Intent to ship. https://groups.google.com/a/chromium.org/forum/#!topic/blink- dev/AT7aqhPcNdw BUG=672982 Review-Url: https://codereview.chromium.org/2560313002 ========== to ========== Flip nav timing 2 runtime flag to experimental. This is to gather early feedback in canary, before we flip this to stable (for M57). Link to Intent to ship. https://groups.google.com/a/chromium.org/forum/#!topic/blink- dev/AT7aqhPcNdw BUG=672982 Committed: https://crrev.com/e7ddc344ea6721070a9f53e539ae9ba0a48b8c77 Cr-Commit-Position: refs/heads/master@{#438013} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/e7ddc344ea6721070a9f53e539ae9ba0a48b8c77 Cr-Commit-Position: refs/heads/master@{#438013} |
