Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(873)

Side by Side Diff: base/check_example.cc

Issue 2559323007: Improve EAT_STREAM_PARAMETERS for Windows x86 (Closed)
Patch Set: back to ps7, extern ostream* Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | base/logging.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // This file is meant for analyzing the code generated by the CHECK 5 // This file is meant for analyzing the code generated by the CHECK
6 // macros in a small executable file that's easy to disassemble. 6 // macros in a small executable file that's easy to disassemble.
7 7
8 #include "base/compiler_specific.h"
8 #include "base/logging.h" 9 #include "base/logging.h"
9 10
10 // An official build shouldn't generate code to print out messages for 11 // An official build shouldn't generate code to print out messages for
11 // the CHECK* macros, nor should it have the strings in the 12 // the CHECK* macros, nor should it have the strings in the
12 // executable. 13 // executable. It is also important that the CHECK() function collapse to the
14 // same implementation as RELEASE_ASSERT(), in particular on Windows x86.
15 // Historically, the stream eating caused additional unnecessary instructions.
16 // See https://crbug.com/672699.
17
18 #define BLINK_RELEASE_ASSERT_EQUIVALENT(assertion) \
19 (UNLIKELY(!(assertion)) ? (IMMEDIATE_CRASH()) : (void)0)
13 20
14 void DoCheck(bool b) { 21 void DoCheck(bool b) {
15 CHECK(b) << "DoCheck " << b; 22 CHECK(b) << "DoCheck " << b;
16 } 23 }
17 24
25 void DoBlinkReleaseAssert(bool b) {
26 BLINK_RELEASE_ASSERT_EQUIVALENT(b);
27 }
28
18 void DoCheckEq(int x, int y) { 29 void DoCheckEq(int x, int y) {
19 CHECK_EQ(x, y); 30 CHECK_EQ(x, y);
20 } 31 }
21 32
22 int main(int argc, const char* argv[]) { 33 int main(int argc, const char* argv[]) {
23 DoCheck(argc > 1); 34 DoCheck(argc > 1);
24 DoCheckEq(argc, 1); 35 DoCheckEq(argc, 1);
36 DoBlinkReleaseAssert(argc > 1);
25 } 37 }
OLDNEW
« no previous file with comments | « no previous file | base/logging.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698