sdk/lib/_internal/compiler/implementation/js_emitter/interceptor_emitter.dart - Issue 255843005: Avoid generating VariableUse nodes with non-identifier names

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/_internal/compiler/implementation/js_emitter/interceptor_emitter.dart

Issue 255843005: Avoid generating VariableUse nodes with non-identifier names (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« sdk/lib/_internal/compiler/implementation/js/nodes.dart ('K') | « sdk/lib/_internal/compiler/implementation/js_emitter/code_emitter_task.dart ('k') | sdk/lib/_internal/compiler/implementation/js_emitter/reflection_data_parser.dart » ('j') | sdk/lib/_internal/compiler/implementation/js_emitter/type_test_emitter.dart » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: sdk/lib/_internal/compiler/implementation/js_emitter/interceptor_emitter.dart

diff --git a/sdk/lib/_internal/compiler/implementation/js_emitter/interceptor_emitter.dart b/sdk/lib/_internal/compiler/implementation/js_emitter/interceptor_emitter.dart

index 233a653f3e0dba47db521186214311163a6c9469..f206e60e025a3349d0cfdd1c6de91a331ff40ddf 100644

--- a/sdk/lib/_internal/compiler/implementation/js_emitter/interceptor_emitter.dart

+++ b/sdk/lib/_internal/compiler/implementation/js_emitter/interceptor_emitter.dart

@@ -414,7 +414,7 @@ class InterceptorEmitter extends CodeEmitterHelper {

if (!analysis.needsClass(classElement)) continue;

elements.add(backend.emitter.constantReference(constant));

- elements.add(js(namer.isolateAccess(classElement)));

+ elements.add(namer.elementAccess(classElement));

// Create JavaScript Object map for by-name lookup of generative

// constructors. For example, the class A has three generative

@@ -436,8 +436,7 @@ class InterceptorEmitter extends CodeEmitterHelper {

properties.add(

new jsAst.Property(

js.string(member.name),

- new jsAst.VariableUse(

- backend.namer.isolateAccess(member))));

+ backend.namer.elementAccess(member)));

}

var map = new jsAst.ObjectInitializer(properties);