sdk/lib/_internal/compiler/implementation/js_backend/checked_mode_helpers.dart - Issue 255843005: Avoid generating VariableUse nodes with non-identifier names

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/_internal/compiler/implementation/js_backend/checked_mode_helpers.dart

Issue 255843005: Avoid generating VariableUse nodes with non-identifier names (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« sdk/lib/_internal/compiler/implementation/js/nodes.dart ('K') | « sdk/lib/_internal/compiler/implementation/js_backend/backend.dart ('k') | sdk/lib/_internal/compiler/implementation/js_backend/constant_emitter.dart » ('j') | sdk/lib/_internal/compiler/implementation/js_emitter/type_test_emitter.dart » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: sdk/lib/_internal/compiler/implementation/js_backend/checked_mode_helpers.dart

diff --git a/sdk/lib/_internal/compiler/implementation/js_backend/checked_mode_helpers.dart b/sdk/lib/_internal/compiler/implementation/js_backend/checked_mode_helpers.dart

index 5b3efd862f4492f5bc1083696257b93e1610f699..caf52b060308fbc781b40c46fe59a72f863af1de 100644

--- a/sdk/lib/_internal/compiler/implementation/js_backend/checked_mode_helpers.dart

+++ b/sdk/lib/_internal/compiler/implementation/js_backend/checked_mode_helpers.dart

@@ -19,8 +19,8 @@ class CheckedModeHelper {

codegen.use(node.checkedInput);

arguments.add(codegen.pop());

generateAdditionalArguments(codegen, node, arguments);

- String helperName = codegen.backend.namer.isolateAccess(helperElement);

- return new jsAst.Call(new jsAst.VariableUse(helperName), arguments);

+ jsAst.Expression helper = codegen.backend.namer.elementAccess(helperElement);

+ return new jsAst.Call(helper, arguments);

}

void generateAdditionalArguments(SsaCodeGenerator codegen,