sdk/lib/_internal/compiler/implementation/js_emitter/reflection_data_parser.dart - Issue 255843005: Avoid generating VariableUse nodes with non-identifier names

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/_internal/compiler/implementation/js_emitter/reflection_data_parser.dart

Issue 255843005: Avoid generating VariableUse nodes with non-identifier names (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « sdk/lib/_internal/compiler/implementation/js_emitter/interceptor_emitter.dart ('k') | sdk/lib/_internal/compiler/implementation/js_emitter/type_test_emitter.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: sdk/lib/_internal/compiler/implementation/js_emitter/reflection_data_parser.dart

diff --git a/sdk/lib/_internal/compiler/implementation/js_emitter/reflection_data_parser.dart b/sdk/lib/_internal/compiler/implementation/js_emitter/reflection_data_parser.dart

index 5509430c764786a6bd6e74a5bbc4716f3dc73677..a667a6a434ea00f37cf144d31d74782f95da9a21 100644

--- a/sdk/lib/_internal/compiler/implementation/js_emitter/reflection_data_parser.dart

+++ b/sdk/lib/_internal/compiler/implementation/js_emitter/reflection_data_parser.dart

@@ -24,6 +24,7 @@ jsAst.Expression getReflectionDataParser(String classesCollector,

String tearOffGlobalObjectName;

String tearOffGlobalObject;

if (closureFromTearOff != null) {

+ // TODO(sra): Replace with AST.

tearOffAccess = namer.isolateAccess(closureFromTearOff);

tearOffGlobalObjectName = tearOffGlobalObject =

namer.globalObjectFor(closureFromTearOff);