Avoid generating VariableUse nodes with non-identifier names

sdk/lib/_internal/compiler/implementation/js/nodes.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 part of js;
 
 abstract class NodeVisitor<T> {
   T visitProgram(Program node);
 
   T visitBlock(Block node);
@@ skipping 682 matching lines @@
   accept(NodeVisitor visitor) => visitor.visitPostfix(this);
 
   int get precedenceLevel => UNARY;
 }
 
 abstract class VariableReference extends Expression {
   final String name;
 
   // We treat operators as if they were special functions. They can thus be
   // referenced like other variables.
-  VariableReference(this.name);
+  VariableReference(this.name) {
+    assert(_identiferOrOperatorRE.hasMatch(name));
+  }
+  static RegExp _identiferOrOperatorRE =

[floitsch, 2014/04/28 14:17:51]

identifierOrOperatorRE  (missing "i")

[sra1, 2014/04/28 23:00:41]

Done.

+            new RegExp(r'^([A-Za-z_$][A-Za-z_$0-9]*|[-<=>+\*\/%^!|&~,]*)$');

[floitsch, 2014/04/28 14:17:51]

you don't need to escape '*' inside a character group. nor "/".

[sra1, 2014/04/28 23:00:41]

'Done'.  After the operators cl, the test is just for an identifier.

 
   accept(NodeVisitor visitor);
   int get precedenceLevel => PRIMARY;
   void visitChildren(NodeVisitor visitor) {}
 }
 
 class VariableUse extends VariableReference {
   VariableUse(String name) : super(name);
 
   accept(NodeVisitor visitor) => visitor.visitVariableUse(this);
@@ skipping 277 matching lines @@
  */
 class Comment extends Statement {
   final String comment;
 
   Comment(this.comment);
 
   accept(NodeVisitor visitor) => visitor.visitComment(this);
 
   void visitChildren(NodeVisitor visitor) {}
 }