Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(534)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 255503006: webui: remove the precendent for silly, invalid end of jsdoc comments, e.g. (Closed)

Created:
6 years, 8 months ago by Dan Beam
Modified:
6 years, 8 months ago
Reviewers:
sky, Evan Stade
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, extensions-reviews_chromium.org, Ilya Sherman, dyu1, yukishiino+watch_chromium.org, benquan, tfarina, nona+watch_chromium.org, dbeam+watch-options_chromium.org, Dane Wallinga, oshima+watch_chromium.org, estade+watch_chromium.org, chromium-apps-reviews_chromium.org, stevenjb+watch_chromium.org, rouslan+autofillwatch_chromium.org, yusukes+watch_chromium.org
Visibility:
Public.

Description

webui: remove the precendent for silly, invalid end of jsdoc comments, e.g. /** * Some doc comment. **/ <-- this I've had to tell people to change **/ -> */ more times than I can count. Also make myself an OWNER of a webui testing directory. R=estade@chromium.org, sky@chromium.org BUG=366972 TEST=less review comments NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266237

Patch Set 1 : whoops #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -28 lines) Patch
M chrome/browser/ui/webui/app_list/start_page_browsertest.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/extensions/chromeos/kiosk_apps_browsertest.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/options/autofill_options_browsertest.js View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/webui/options/certificate_manager_browsertest.js View 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/webui/options/chromeos/accounts_options_browsertest.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/options/content_options_browsertest.js View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/options/content_settings_exception_area_browsertest.js View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/options/cookies_view_browsertest.js View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/options/edit_dictionary_browsertest.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/options/font_settings_browsertest.js View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/options/language_options_dictionary_download_browsertest.js View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/options/password_manager_browsertest.js View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/options/profile_settings_reset_browsertest.js View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/options/search_engine_manager_browsertest.js View 2 chunks +2 lines, -2 lines 0 comments Download
A + chrome/test/data/webui/OWNERS View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/test/data/webui/about_invalidations_browsertest.js View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
Dan Beam
6 years, 8 months ago (2014-04-24 22:02:08 UTC) #1
sky
sky->estade
6 years, 8 months ago (2014-04-24 23:01:49 UTC) #2
Evan Stade
lgtm
6 years, 8 months ago (2014-04-25 00:35:45 UTC) #3
Dan Beam
sky@: still need your stamp for chrome/test
6 years, 8 months ago (2014-04-25 00:37:31 UTC) #4
sky
Sorry, LGTM As you piqued my curiosity, where is the style guide I should be ...
6 years, 8 months ago (2014-04-25 15:27:44 UTC) #5
tfarina
On Fri, Apr 25, 2014 at 12:27 PM, <sky@chromium.org> wrote: > Sorry, LGTM > > ...
6 years, 8 months ago (2014-04-25 16:02:04 UTC) #6
sky
Thanks! On Fri, Apr 25, 2014 at 9:01 AM, Thiago Farina <tfarina@chromium.org> wrote: > > ...
6 years, 8 months ago (2014-04-25 16:03:57 UTC) #7
Dan Beam
On 2014/04/25 15:27:44, sky wrote: > Sorry, LGTM > > As you piqued my curiosity, ...
6 years, 8 months ago (2014-04-25 18:15:43 UTC) #8
Dan Beam
The CQ bit was checked by dbeam@chromium.org
6 years, 8 months ago (2014-04-25 18:15:51 UTC) #9
Dan Beam
6 years, 8 months ago (2014-04-25 20:47:48 UTC) #10
Message was sent while issue was closed. 
Committed patchset #1 manually as r266237 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698