Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1129)

Issue 25549003: Fix running 'import run_isolated' at python interactive prompt. (Closed)

Created:
7 years, 2 months ago by M-A Ruel
Modified:
7 years, 2 months ago
Reviewers:
Vadim Sh.
CC:
chromium-reviews, csharp+cc_chromium.org, vadimsh+cc_chromium.org, maruel+cc_chromium.org
Base URL:
https://chromium.googlesource.com/a/chromium/tools/swarm_client@1_update_item
Visibility:
Public.

Description

Fix running 'import run_isolated' at python interactive prompt. This was breaking 'import swarming' since it imports run_isolated. swarming.py: - Rename manifest_hash to isolated_hash, the previous name was confusing. - Only add the data section if necessary, if .zip_and_upload() was called. - Assumes slave_os is already the proper key in PLATFORM_MAPPING_SWARMING. - Have polling quit sooner. R=vadimsh@chromium.org BUG= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=226272

Patch Set 1 #

Total comments: 3

Patch Set 2 : Added comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -27 lines) Patch
M run_isolated.py View 1 2 chunks +10 lines, -3 lines 0 comments Download
M swarming.py View 9 chunks +26 lines, -14 lines 0 comments Download
M tests/swarming_test.py View 5 chunks +7 lines, -8 lines 0 comments Download
M utils/net.py View 1 chunk +1 line, -1 line 0 comments Download
M utils/zip_package.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
M-A Ruel
7 years, 2 months ago (2013-10-01 18:48:22 UTC) #1
Vadim Sh.
lgtm with nit https://codereview.chromium.org/25549003/diff/1/run_isolated.py File run_isolated.py (right): https://codereview.chromium.org/25549003/diff/1/run_isolated.py#newcode42 run_isolated.py:42: MAIN_DIR = ( nit: I'd change ...
7 years, 2 months ago (2013-10-01 18:59:50 UTC) #2
M-A Ruel
https://codereview.chromium.org/25549003/diff/1/run_isolated.py File run_isolated.py (right): https://codereview.chromium.org/25549003/diff/1/run_isolated.py#newcode42 run_isolated.py:42: MAIN_DIR = ( On 2013/10/01 18:59:51, Vadim Sh. wrote: ...
7 years, 2 months ago (2013-10-01 19:06:35 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/maruel@chromium.org/25549003/7001
7 years, 2 months ago (2013-10-01 19:06:40 UTC) #4
commit-bot: I haz the power
7 years, 2 months ago (2013-10-01 19:08:02 UTC) #5
Message was sent while issue was closed.
Change committed as 226272

Powered by Google App Engine
This is Rietveld 408576698