Issue 25548009: Centralize handler caching and probing in ic.cc.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 25548009: Centralize handler caching and probing in ic.cc. (Closed)

Created:
7 years, 2 months ago by Toon Verwaest

Modified:
7 years, 2 months ago

Reviewers:
ulan

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Centralize handler caching and probing in ic.cc. Also purge invalid POLYMORPHIC stubs. In a next step the compilers should probably be merged and the "Compute*" on the stub-cache removed. BUG= R=ulan@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=17161

Patch Set 1 #

Patch Set 2 : Fix removing monomorphic handlers #

Patch Set 3 : Rebase #

Patch Set 4 : Undo moving fallback IC handling #

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+120 lines, -192 lines)			Patch
M	src/ic.h	View		5 chunks	+12 lines, -5 lines	0 comments	Download
M	src/ic.cc	View	1 2 3	10 chunks	+69 lines, -23 lines	0 comments	Download
M	src/objects.h	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/stub-cache.h	View		1 chunk	+4 lines, -8 lines	0 comments	Download
M	src/stub-cache.cc	View		18 chunks	+34 lines, -155 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Toon Verwaest

7 years, 2 months ago (2013-10-11 13:48:20 UTC) #3

Message was sent while issue was closed.

Committed patchset #4 manually as r17161 (presubmit successful).

Expand Messages | Collapse Messages