Use PatchCache for call ICs.

Use PatchCache for call ICs.

R=ulan@chromium.org

Committed: https://code.google.com/p/v8/source/detail?r=17088

[Toon Verwaest, 2013-10-01 16:17:49]

PTAL.

[ulan, 2013-10-02 08:45:24]

https://chromiumcodereview.appspot.com/25464004/diff/1/src/ic.cc
File src/ic.cc (left):

https://chromiumcodereview.appspot.com/25464004/diff/1/src/ic.cc#oldcode755
src/ic.cc:755: argc, kind_, extra_ic_state());
Why are we removing these cases?

[Toon Verwaest, 2013-10-02 08:56:05]

https://chromiumcodereview.appspot.com/25464004/diff/1/src/ic.cc
File src/ic.cc (left):

https://chromiumcodereview.appspot.com/25464004/diff/1/src/ic.cc#oldcode755
src/ic.cc:755: argc, kind_, extra_ic_state());
They aren't removed, they are just folded in the existing implementation.

They are available implicitly.
TryRemoveInvalidPrototypeDependentStub will first do TryUpdateExtraICState
before running the rest of the code; which will result in
MONOMORPHIC_PROTOTYPE_FAILURE, hence it'll stay MONOMORPHIC.

When it was already MONOMORPHIC, it'll try to go POLYMORPHIC, but that won't
work out since there are never handlers for calls atm (of course we want to get
those in the future). So it'll go megamorphic. It'll call the virtual
"megamorphic_stub()" method to create it, which is now overwritten to do
ComputeCallMegamorphic.

On 2013/10/02 08:45:24, ulan wrote:
> Why are we removing these cases?

[ulan, 2013-10-02 09:42:03]

Thanks, LGTM

[Toon Verwaest, 2013-10-02 17:21:04]

Committed patchset #1 manually as r17088 (presubmit successful).