chrome/browser/extensions/extension_prefs.h - Issue 25366003: Moved some functions off ExtensionService into a new file extension_util.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extension_prefs.h

Issue 25366003: Moved some functions off ExtensionService into a new file extension_util. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Windows compile Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/extension_functional_browsertest.cc ('k') | chrome/browser/extensions/extension_prefs.cc » ('j') | chrome/browser/extensions/extension_service.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/extension_prefs.h

diff --git a/chrome/browser/extensions/extension_prefs.h b/chrome/browser/extensions/extension_prefs.h

index 22a00b154a4d0c42121f7192739ff812d15ec2ea..b52047b21ec59501e4c920732881d90275396b1f 100644

--- a/chrome/browser/extensions/extension_prefs.h

+++ b/chrome/browser/extensions/extension_prefs.h

@@ -371,12 +371,12 @@ class ExtensionPrefs : public ExtensionScopedPrefs,

// IMPORTANT: you probably want to use ExtensionService::IsIncognitoEnabled

Yoyo Zhou 2013/10/15 21:25:49 Comment needs to be updated.

benwells 2013/10/17 06:56:55 Done.

// instead of this method.

- bool IsIncognitoEnabled(const std::string& extension_id);

+ bool IsIncognitoEnabled(const std::string& extension_id) const;

void SetIsIncognitoEnabled(const std::string& extension_id, bool enabled);

// Returns true if the user has chosen to allow this extension to inject

// scripts into pages with file URLs.

Yoyo Zhou 2013/10/15 21:25:49 Probably should have a similar comment.

benwells 2013/10/17 06:56:55 Done.

- bool AllowFileAccess(const std::string& extension_id);

+ bool AllowFileAccess(const std::string& extension_id) const;

void SetAllowFileAccess(const std::string& extension_id, bool allow);

bool HasAllowFileAccessSetting(const std::string& extension_id) const;