chrome/browser/ui/gtk/browser_actions_toolbar_gtk.cc - Issue 25366003: Moved some functions off ExtensionService into a new file extension_util.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/gtk/browser_actions_toolbar_gtk.cc

Issue 25366003: Moved some functions off ExtensionService into a new file extension_util. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Compile failures Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/cocoa/extensions/browser_actions_controller.mm ('k') | chrome/browser/ui/views/browser_actions_container.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/gtk/browser_actions_toolbar_gtk.cc

diff --git a/chrome/browser/ui/gtk/browser_actions_toolbar_gtk.cc b/chrome/browser/ui/gtk/browser_actions_toolbar_gtk.cc

index 34f300ac07e04720260efa3d538186ec84698fb7..d2f056b3e20de48ca80a281cb1e4983e5efaf2ea 100644

--- a/chrome/browser/ui/gtk/browser_actions_toolbar_gtk.cc

+++ b/chrome/browser/ui/gtk/browser_actions_toolbar_gtk.cc

@@ -21,6 +21,7 @@

#include "chrome/browser/extensions/extension_context_menu_model.h"

#include "chrome/browser/extensions/extension_service.h"

#include "chrome/browser/extensions/extension_system.h"

+#include "chrome/browser/extensions/extension_util.h"

#include "chrome/browser/profiles/profile.h"

#include "chrome/browser/sessions/session_tab_helper.h"

#include "chrome/browser/ui/browser.h"

@@ -694,8 +695,9 @@ bool BrowserActionsToolbarGtk::ShouldDisplayBrowserAction(

const Extension* extension) {

// Only display incognito-enabled extensions while in incognito mode.

return (!profile_->IsOffTheRecord() ||

- extensions::ExtensionSystem::Get(profile_)->extension_service()->

- IsIncognitoEnabled(extension->id()));

+ extension_util:: IsIncognitoEnabled(

+ extension->id(),

+ extensions::ExtensionSystem::Get(profile_)->extension_service()));

}

void BrowserActionsToolbarGtk::HidePopup() {